Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add dropdown to make user an org admin workspaces #1771

Merged
merged 1 commit into from
Mar 5, 2025

Conversation

radekkaluzik
Copy link
Contributor

Description

Added dropdown to make user an org admin for workspaces

RHCLOUD-37492


Screenshots

Snímek obrazovky 2025-02-28 v 15 03 51

Checklist ☑️

  • PR only fixes one issue or story
  • Change reviewed for extraneous code
  • UI best practices adhered to
  • Commits squashed and meaningfully named
  • All PR checks pass locally (build, lint, test, E2E)

  • (Optional) QE: Needs QE attention (OUIA changed, perceived impact to tests, no test coverage)
  • (Optional) QE: Has been mentioned
  • (Optional) UX: Needs UX attention (end user UX modified, missing designs)
  • (Optional) UX: Has been mentioned

@radekkaluzik radekkaluzik requested a review from a team as a code owner February 28, 2025 14:15
@@ -210,6 +211,23 @@ const UsersTable: React.FunctionComponent<UsersTableProps> = ({ onAddUserClick,
id: user.username,
is_active: user.is_active,
row: [
[
<OrgAdminDropdown
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should hide this behind a feature flag platform.rbac.common-auth-model so if it's not available to show the org.admin as previously. Also only org. admins can change this, so we should toggle between this and static field based on rights.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@radekkaluzik radekkaluzik requested a review from a team as a code owner March 5, 2025 10:16
@radekkaluzik radekkaluzik requested a review from karelhala March 5, 2025 10:17
@karelhala karelhala merged commit b73a7f2 into RedHatInsights:master Mar 5, 2025
6 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants