Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(workspaces): add ability to delete workspace from list view #1776

Merged
merged 2 commits into from
Mar 11, 2025
Merged

feat(workspaces): add ability to delete workspace from list view #1776

merged 2 commits into from
Mar 11, 2025
+104 −23

Conversation

InsaneZein
Copy link
Contributor

Description

Adds ability to delete workspaces from list view using row and bulk action

RHCLOUD-37803

Screenshots

Screenshot from 2025-03-06 13-29-49

Screenshot from 2025-03-06 13-30-32

Checklist ☑️

  • PR only fixes one issue or story
  • Change reviewed for extraneous code
  • UI best practices adhered to
  • Commits squashed and meaningfully named
  • All PR checks pass locally (build, lint, test, E2E)

  • (Optional) QE: Needs QE attention (OUIA changed, perceived impact to tests, no test coverage)
  • (Optional) QE: Has been mentioned
  • (Optional) UX: Needs UX attention (end user UX modified, missing designs)
  • (Optional) UX: Has been mentioned

Sorry, something went wrong.

@InsaneZein InsaneZein requested a review from a team March 6, 2025 19:31
@InsaneZein InsaneZein changed the base branch from delete-workspace-listview to master March 6, 2025 19:31
@InsaneZein InsaneZein requested a review from a team as a code owner March 6, 2025 19:31
@InsaneZein InsaneZein force-pushed the delete-workspace-listview branch from a5a69fc to 24eaf3f Compare March 6, 2025 20:32
apinkert
apinkert approved these changes Mar 10, 2025
View reviewed changes
Copy link
Contributor

@apinkert apinkert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM but we're still missing the api functionality so as long as we're cool with console logging in the meantime

@InsaneZein InsaneZein merged commit 7cbf7df into RedHatInsights:master Mar 11, 2025
5 of 8 checks passed
@InsaneZein InsaneZein deleted the delete-workspace-listview branch March 11, 2025 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apinkert apinkert

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@InsaneZein @apinkert