feat: enable sorting and filtering for users table #1777
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
InsaneZein
reviewed
Mar 7, 2025
| @@ -351,6 +423,21 @@ const UsersTable: React.FunctionComponent<UsersTableProps> = ({ onAddUserClick, | |||
| /> | |||
| } | |||
| pagination={React.cloneElement(paginationComponent, { isCompact: true })} | |||
| filters={ | |||
| <DataViewFilters onChange={(_e, values) => onSetFilters(values)} values={filters}> | |||
| <DataViewTextFilter | |||
There was a problem hiding this comment.
We should add some ouiaIds to DataViewFilters and DataviewTextFilter
|
Could you also add a simple cypress test for filtering and sorting? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
username(Currently the only field supported by the API)usernameandemail(Currently the only fields supported by the API)RHCLOUD-35605
Screenshots
After:
Checklist ☑️