Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.6] MOD-5904: Fix DocTable memsize (#5099) #5816

Merged
merged 2 commits into from
Mar 26, 2025
Merged

Conversation

nafraf
Copy link
Collaborator

@nafraf nafraf commented Mar 21, 2025

Description

Manual backport of #5099 to 2.6.
(cherry picked from commit b4234ed)

Adjustments for 2.6

  • 2.6 does not contain tests/cpptests/test_cpp_llapi.cpp: TEST_F(LLApiTest, testInfoSizeWithExistingIndex)
  • sizeof(DocTable) = 64 bytes, because does not contain TimeToLiveTable* ttl;
  • TEST_F(LLApiTest, testInfoSize) was modified because 2.6 does not contain the changes to count numeric range tree overhead

@nafraf nafraf marked this pull request as ready for review March 21, 2025 14:18
Copy link

codecov bot commented Mar 21, 2025

Codecov Report

Attention: Patch coverage is 57.14286% with 3 lines in your changes missing coverage. Please review.

Project coverage is 85.17%. Comparing base (a19d287) to head (ad20abf).
Report is 2 commits behind head on 2.6.

Files with missing lines Patch % Lines
src/doc_table.c 57.14% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              2.6    #5816      +/-   ##
==========================================
- Coverage   85.18%   85.17%   -0.01%     
==========================================
  Files         185      185              
  Lines       31500    31507       +7     
==========================================
+ Hits        26832    26837       +5     
- Misses       4668     4670       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@nafraf nafraf requested review from kei-nan and raz-mon March 26, 2025 13:26
@nafraf nafraf added this pull request to the merge queue Mar 26, 2025
Merged via the queue into 2.6 with commit 263f4bf Mar 26, 2025
15 of 16 checks passed
@nafraf nafraf deleted the nafraf_backport-5099-to-2.6 branch March 26, 2025 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants