feat(datetime-picker): replace input with datetimeField #408
+1,504
−1,692
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with
|
| Latest commit: |
87c9f7c
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://0d7ac811.refinitiv-ui.pages.dev |
| Branch Preview URL: | https://feature-integrate-datetime-p.refinitiv-ui.pages.dev |
* feat(datetime-field): make locale function public * feat(datetime-picker): refactor element * refactor(datetime-field): make resolveLocale function reusable * feat(phrasebook): add datetime-picker strings * feat(utils): add format checks to Locale object
goremikins
changed the title
…ime-picker-with-datetime-field # Conflicts: # package-lock.json # packages/elements/src/datetime-picker/__test__/datetime-picker.value.test.js # packages/elements/src/datetime-picker/index.ts
wsuwt
reviewed
Aug 22, 2022
| @@ -48,7 +65,7 @@ | |||
| } | |||
|
|
|||
| &[range] { | |||
| ef-text-field { | |||
| ef-datetime-field { | |||
There was a problem hiding this comment.
Would it be better if we style this with part selector ?
There was a problem hiding this comment.
Yes, it should follow other elements and use part selector.
|
SonarCloud Quality Gate failed. |
TremayneChrist
temporarily deployed
to
development
GitHub Actions
Inactive
|
Due to the following concerns, this change would be revisit in the next major release instead.
|
|
Happy Anniversary! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Integrate datetime-field with datetime-picker
Tasks
Type of change
Checklist