Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

extract some methods #8

Merged
merged 31 commits into from
Mar 27, 2012
Merged

extract some methods #8

merged 31 commits into from
Mar 27, 2012

Conversation

iannsp
Copy link
Contributor

@iannsp iannsp commented Mar 27, 2012

this PR start a normalization and responsability separation from Doc to DocItem and Markdown.
those 2 class will receive more changes but Doc not(I hope)
may the force be with u guys

iannsp added 30 commits March 27, 2012 00:34
@iannsp
support reflection class for analize
5054fea
@iannsp
support reflection class for analize
3b29e91
@iannsp
add getDocComment
d772e10
@iannsp
add getDocComment
33d6609
@iannsp
add a reference to DocItem and use getName, getDocComment
d21185e
@iannsp
test getDocComment
ad17aec
@iannsp
add __call to continue development
9e5204e
@iannsp
better call
403b893
@iannsp
use typeHint of DocItem instead Reflection class in getSection
47a657c
@iannsp
test get Methods
f623856
@iannsp
extract getSections from Doc to here
df4f6d5
@iannsp
test getSections
d27110c
@iannsp
test getSections
de0f51b
@iannsp
extract getSections
0905619
@iannsp
getout use clausules
9eca0a6
@iannsp
extract getClassContent algorithms
0250374
@iannsp
insert getClassContent algorithm
696a474
@iannsp
test getClassContent
486027a
@iannsp
a complete output to compare
072f82a
@iannsp
extract class name section index
43f1599
@iannsp
add class name section index
7e3b628
@iannsp
get method private to reduce public interface
a1ad8f0
@iannsp
commit className
8eee113
@iannsp
extract getMarkDown from Doc to here
bd5d233
@iannsp
test get for markdown syntax
d422581
@iannsp
use Markdown class instead getmakrdown method
29c8ecc
@iannsp
get out getmarkdown method
0b956e6
@iannsp
get out unused properties
d8dc01e
@iannsp
use array_merge
80879da
@iannsp
cover analize a NameSpace instead a class
08b976e
alganet pushed a commit that referenced this pull request Mar 27, 2012
Merge pull request #8 from iannsp/master
b017996 
extract some methods
@alganet alganet merged commit b017996 into Respect:master Mar 27, 2012
alganet pushed a commit that referenced this pull request Mar 27, 2012
Merge pull request #8 from iannsp/master
0ed946a 
extract some methods
@alganet
Copy link
Member

alganet commented Mar 27, 2012

Awesome! We really coded this in a rush and needed this separation. Maybe we should also move everything to a namespace now, like Doc/Generator.php, Doc/Item.php and Doc/Markdown.php. What do you think @augustohp?

@augustohp augustohp mentioned this pull request Mar 27, 2012
Open
@augustohp
Copy link
Member

Agreed. At first sight I got sad that the one-class-thing was gone. But after i opened it and saw the Doc class the way it is now, I got happy again.

I sure have to improve the Doc\Item.php class, but awesome work @iannsp !

+1 into namespaced classes. I am opening an issue to this: #9

@iannsp
Copy link
Contributor Author

iannsp commented Mar 27, 2012

guys, it's just the first step to a newer version.
Hope finish this soon, probably tonight or tomorrow.
Have lot to do in DocItem and MarkDown yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@iannsp @alganet @augustohp