Throw an exception when age is not an integer

Respect · Apr 24, 2016 · cca7339 · cca7339
1 parent 9460a4c
commit cca7339
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 4 deletions.
diff --git a/library/Rules/MinimumAge.php b/library/Rules/MinimumAge.php
@@ -12,6 +12,7 @@
 namespace Respect\Validation\Rules;
 
 use DateTime;
+use Respect\Validation\Exceptions\ComponentException;
 
 class MinimumAge extends AbstractRule
 {
@@ -20,16 +21,16 @@ class MinimumAge extends AbstractRule
 
     public function __construct($age, $format = null)
     {
+        if (!filter_var($age, FILTER_VALIDATE_INT)) {
+            throw new ComponentException('The age must be a integer value.');
+        }
+
         $this->age = $age;
         $this->format = $format;
     }
 
     public function validate($input)
     {
-        if (!filter_var($this->age, FILTER_VALIDATE_INT)) {
-            return false;
-        }
-
         if ($input instanceof DateTime) {
             $birthday = new \DateTime('now - '.$this->age.' year');
 

diff --git a/tests/unit/Rules/MininumAgeTest.php b/tests/unit/Rules/MininumAgeTest.php
@@ -51,6 +51,15 @@ public function testInvalidDateShouldNotPass($age, $format, $input)
         $this->assertFalse($minimumAge->assert($input));
     }
 
+    /**
+     * @expectedException Respect\Validation\Exceptions\ComponentException
+     * @expectedExceptionMessage The age must be a integer value
+     */
+    public function testShouldNotAcceptNonIntegerAgeOnConstructor()
+    {
+        new MinimumAge('L12');
+    }
+
     public function providerForValidDateValidMinimumAge()
     {
         return [