Create "Templated" rule #1510
Merged
Create "Templated" rule #1510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1510 +/- ##
============================================
- Coverage 96.52% 96.51% -0.02%
+ Complexity 966 964 -2
============================================
Files 201 202 +1
Lines 2388 2379 -9
============================================
- Hits 2305 2296 -9
Misses 83 83 ☔ View full report in Codecov by Sentry. |
henriquemoody
force-pushed
the
core/templated
branch
4 times, most recently
from
6a33f16 to
f57f9b4
Compare
Because of how the validation engine works, there's no reason to keep adding templates to each rule. Instead, creating a single rule that handles templating rules will simplify the library greatly and shrink the `Rule` interface. Personally, I think this API is much more straightforward than the `setTemplate()` method, as it's way more explicit which rule is being templated.
henriquemoody
force-pushed
the
core/templated
branch
from
f57f9b4 to
1d1da7f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because of how the validation engine works, there's no reason to keep adding templates to each rule. Instead, creating a single rule that handles templating rules will simplify the library greatly and shrink the
Ruleinterface.