Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify the StandardFormatter #1525

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Unrelated: remove the responsibility of formatter to select templates

661ce71
Select commit
Loading
Failed to load commit list.
Draft

Simplify the StandardFormatter #1525

Unrelated: remove the responsibility of formatter to select templates
661ce71
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Dec 27, 2024 in 0s

96.23% (target 95.00%)

View this Pull Request on Codecov

96.23% (target 95.00%)

Details

Codecov Report

Attention: Patch coverage is 91.21622% with 13 lines in your changes missing coverage. Please review.

Project coverage is 96.23%. Comparing base (a0d6355) to head (661ce71).

Files with missing lines Patch % Lines
library/ResultSet.php 78.57% 9 Missing ⚠️
library/Message/TemplateSelector.php 86.66% 4 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1507      +/-   ##
============================================
- Coverage     96.64%   96.23%   -0.42%     
- Complexity      999     1035      +36     
============================================
  Files           205      207       +2     
  Lines          2477     2548      +71     
============================================
+ Hits           2394     2452      +58     
- Misses           83       96      +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.