Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added new features #98

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

Anushkaagrawal22
Copy link

Added features for sending emoji's, attachments , stickers, images
image

Added features for sending emoji's, attachments , stickers, images
@Anushkaagrawal22
Copy link
Author

I'll also add the feature to set color and font by tomorrow.

@Anushkaagrawal22
Copy link
Author

Also, can anyone send the image used as emoji in qt interface?

@Anushkaagrawal22
Copy link
Author

image
I have attached the feature to change color and font and also added the send message button.

emojiPicker.style.display = emojiPicker.style.display === 'none' ? 'block' : 'none';
},
}, m('img', {
src: "https://i.pinimg.com/736x/e4/47/1f/e4471fd12da05d58e102f8acee595162.jpg", alt: 'Emoji'})),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do not use an external resource. This can break the anonymity of Tor nodes because i.pinimg.com will get your IP when you perform the request.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okk sir, I will change it.

const attachmentInput = document.querySelector('.chatAttachment');
attachmentInput.click();
},
}, m('img', { src: "https://encrypted-tbn0.gstatic.com/images?q=tbn:ANd9GcQQ6k7KXoSJ7iY0HurPvwJsx_g59l6xS5ltOQ&s", alt: 'Attach' })), // Ensure the path is correct
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here

@csoler
Copy link
Contributor

csoler commented Mar 9, 2025

  • please remove all explicit calls to external websites (this compromises anonymity of nodes)
  • why is the changes for styles.css so large??

@Anushkaagrawal22
Copy link
Author

Anushkaagrawal22 commented Mar 9, 2025

  • please remove all explicit calls to external websites (this compromises anonymity of nodes)

Yes sir, I will do that

  • why is the changes for styles.css so large??

Sir, I formatted style.css so that it is easier to understand the code when i was reading the code . I didn't change many things in style.css but due to formatting the change is looking very large. I am sorry for that I will remember to check my pr carefully.

@Anushkaagrawal22
Copy link
Author

Anushkaagrawal22 commented Mar 11, 2025

@csoler should i commit style.css file or not for my next pr

@zelfroster
Copy link
Contributor

zelfroster commented Mar 11, 2025

@csoler should i commit style.css file or not for my next pr

It looks like that this big change has been created due to your code editor's formatting.

So, @Anushkaagrawal22 I will suggest, first you run pnpm build once and then commit the style.css file again here in this PR.

Also, you don't have to edit style.css manually, since it is generated from your scss styles only.

@Anushkaagrawal22
Copy link
Author

@csoler should i commit style.css file or not for my next pr

It looks like that this big change has been created due to your code editor's formatting.

Yes @zelfroster this was the reason

So, @Anushkaagrawal22 I will suggest, first you run pnpm build once and then commit the style.css file again here in this PR.

I did as you said

Also, you don't have to edit style.css manually, since it is generated from your scss styles only.
Ok @zelfroster

@csoler
Copy link
Contributor

csoler commented Mar 16, 2025

This PR still contains several explicit http links.

@Anushkaagrawal22
Copy link
Author

This PR still contains several explicit http links.

Yes actually i am still working on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants