Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Test if Package.swift is valid on CI for older tooling #4697

Open
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

facumenzella
Copy link
Contributor

@facumenzella facumenzella commented Jan 22, 2025

Motivation

This PR aims to add a quick way of validating Package.swift. At least the version that are not tested on every PR (so probably only 5.7 and 5.8 are enough)

Tons of things failed on the last release #4692, and this was one of them.

I did it in different jobs because I wasn't sure how to swap Xcode versions, but happy to reuse the same job if someone knows how to. Didn't dig much into it

Screenshot 2025-01-22 at 18 28 09

@facumenzella facumenzella marked this pull request as ready for review January 22, 2025 17:32
@facumenzella facumenzella requested a review from vegaro January 22, 2025 17:32
@facumenzella facumenzella changed the title chore: Test if Package.swift is valid on CI chore: Test if Package.swift is valid on CI for older tooling Jan 22, 2025
@nguyenhuy
Copy link
Contributor

nguyenhuy commented Jan 23, 2025

2 cents from a bystander:

This is nice! 5.15.0 didn't seem to go out smoothly to me (so was 5.14.0). Agree that the Swift package files should have been validated by CI per-commit.

Another problem I noticed is related to pbxproj. Any plan to stop tracking it (xcodeproj in general)? I myself encountered merge conflicts while working on my branches. It just doesn't scale as you welcome more developers and bots to the project.

Pinterest stopped tracking xcodeproj many many years ago. xcodegen works well for us. So did Tulsi back when we built with bazel.

Xcode 16's buildable folders looks promising. Perhaps you are holding out for it?

@facumenzella
Copy link
Contributor Author

Another problem I noticed is related to pbxproj. Any plan to stop tracking it (xcodeproj in general)? I myself encountered merge conflicts while working on my branches. It just doesn't scale as you welcome more developers and bots to the project.

@nguyenhuy the plan is to integrate tuist at some point. So yes, it will eventually disappear =)

@nguyenhuy
Copy link
Contributor

nguyenhuy commented Jan 23, 2025

@facumenzella That's great to hear! If it was up to me I'd put it quite high on my list, because:

  1. It has to be done anyways
  2. It'll offer productivity boost from day one
  3. It honestly isn't complicated to set up (speaking from my experience with XcodeGen and assuming it'd apply to Tuist). And you can timebox it.

But of course you all have the complete picture of the read map and priorities so it's your call.

@facumenzella facumenzella force-pushed the chore/test-validity-package.swift branch from 6551462 to 774dc6f Compare January 23, 2025 16:39
Copy link
Member

@aboedo aboedo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is great! :chefskiss:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants