[Paywalls V2] Support generic fonts #4766
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshdholtz
commented
Feb 6, 2025
| @@ -261,25 +259,58 @@ struct TextComponentStyle { | |||
|
|
|||
| } | |||
|
|
|||
| enum GenericFont: String { | |||
|
|
|||
| case serif, monospace, sansSerif = "sans-serif" | |||
There was a problem hiding this comment.
@JayShortway @tonidero Does this casing for sans-serif match what Android has? I couldn't tell 😅
There was a problem hiding this comment.
Yes! This seems correct. FWIW, in Android, I believe we're using the font family name, which matches to serif, monospace and sans-serif.
tonidero
approved these changes
Feb 6, 2025
| uiConfigProvider: UIConfigProvider | ||
| ) -> Font? { | ||
| guard let familyName = uiConfigProvider.getFontFamily(for: name) else { | ||
| Logger.warning("Maping for '\(name)' could not be found. Falling back to system font.") |
There was a problem hiding this comment.
Suggested change
| Logger.warning("Maping for '\(name)' could not be found. Falling back to system font.") | |
| Logger.warning("Mapping for '\(name)' could not be found. Falling back to system font.") |
JayShortway
approved these changes
Feb 6, 2025
MarkVillacampa
approved these changes
Feb 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Support generic fonts for serif and monospace
Description
TextComponentStylestill mapserif,sansserif, andmonospaceto generic system fonts