Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix period abbreviated when multiple days/weeks/months/years #4769

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Fix period abbreviated when multiple days/weeks/months/years #4769

wants to merge 4 commits into from
+94 −3

Conversation

joshdholtz
Copy link
Member

@joshdholtz joshdholtz commented Feb 6, 2025 •
edited
Loading

⚠️ Dependent on a backend PR to be merged first with the new keys

Motivation

The period abbreviation when multiple months was rendering as months or mo instead of 3 months or 3mo

Description

Four new localization keys for abbreviated days/weeks/months/years

@joshdholtz joshdholtz force-pushed the paywalls-v2/fix-period-abbreviated branch from 6f9c7b2 to fd25a1f Compare February 6, 2025 17:54
@joshdholtz joshdholtz requested review from a team February 6, 2025 17:57
@joshdholtz joshdholtz marked this pull request as ready for review February 6, 2025 17:57
@joshdholtz joshdholtz force-pushed the paywalls-v2/fix-period-abbreviated branch from fd25a1f to 449f936 Compare February 6, 2025 18:00
tonidero
tonidero approved these changes Feb 7, 2025
View reviewed changes
Copy link
Contributor

@tonidero tonidero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Tests/RevenueCatUITests/PaywallsV2/VariableHandlerV2Tests.swift Outdated Show resolved Hide resolved
ajpallares
ajpallares approved these changes Feb 7, 2025
View reviewed changes
Copy link
Member

@ajpallares ajpallares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just a very small comment

RevenueCatUI/Templates/V2/Variables/VariableHandlerV2.swift Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tonidero tonidero tonidero approved these changes

@ajpallares ajpallares ajpallares approved these changes

Assignees
No one assigned
Labels
do not merge feat:PaywallV2 pr:fix A bug fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@joshdholtz @tonidero @ajpallares