Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Realm code #19

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Update Realm code #19

wants to merge 2 commits into from

Conversation

mateusgrb
Copy link

  1. It doesn't make sense to iterate through all address books to call insert methods for contacts and address items as when you call realm.insertOrUpdate(finalAddressBooks), all contacts and addresses referenced are also inserted. This is similar to DBFlowTester calling only Saver.saveAll(finalAddressBooks), without needing to call this same method for contacts and address items.

  2. Call insertOrUpdate() instead of copyToRealm(), as we are concerned only about inserting these entities, and not retrieving the newly inserted items. insertOrUpdate() doesn't return the inserted entites, and as stated in the docs, this makes it run faster.

  3. Update Realm version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant