-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Different Default-Colours Wrapping #347
base: master
Are you sure you want to change the base?
Conversation
include/Color.hpp
Outdated
|
||
/** | ||
* Returns src alpha-blended into dst color with tint | ||
*/ | ||
[[nodiscard]] Color AlphaBlend(::Color dst, ::Color tint) const { return ::ColorAlphaBlend(dst, *this, tint); } | ||
|
||
/* I think it deprecated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Feel free to remove the old functions, I agree we shouldn't need these with the const expressions. May need to update some oft he examples though.
include/Color.hpp
Outdated
/** | ||
* As an alternative to a function calling convention | ||
*/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will become the doxygen docs for LightGray. It might be best to just remove the block as it's pretty clear what it does 😎
/** | |
* As an alternative to a function calling convention | |
*/ |
Deleting Colour Functions and setting the const-expressions to static, because I forgot to do that
I think that's it? |
Oh wait the examples... |
Getting the following error...
I believe it's because
Since it expands with Not entirely sure if that's correct, but I'm not sure of a good workaround. |
the problem ist that a static constexpr can not be from the same type the class it is defined in, |
ooh hehe, some function-wrappers don't take the Color class... |
No time urgency. Take all the time you need :) As long as Color.hpp builds, it'll be easy to find/replace the Color usage. |
Pulling the default colours out of the Color Class. Don’t know if it’s a good idea though.
|
Didn't update the docs yet and also don't really know if it's a good idea, or if it works at all, I'm not on Desktop so can't build |
I was wondering about the implementation of the Colour that are already provided by raylib... why functions?
If there is a reason, I'm sorry, please explain.
But in the mean time I changed them to
constexpr
's.