Ensure all ROS 2 Bazel projects use .bazelrc testing setup #297
Conversation
EricCousineau-TRI
force-pushed
the
feature-same-bazelrc
branch
2 times, most recently
from
4b769a8
to
0ac5be7
Compare
There was a problem hiding this comment.
+@IanTheEngineer for review, please! I could use some help on organizing, though - if you have suggestions, could I ask you to make a meta PR?
\cc @calderpg-tri
Reviewable status: 0 of 23 files reviewed, all discussions resolved (waiting on @IanTheEngineer)
There was a problem hiding this comment.
Reviewable status: 0 of 23 files reviewed, 1 unresolved discussion (waiting on @EricCousineau-TRI and @IanTheEngineer)
a discussion (no related file):
Working: This PR currently does two things - try to ensure build flags are the same to help caching, and then ensure test flags are the same to force isolation.
I'm going to split the caching portion off of this, and make this PR only responsible for isolation flags.
EricCousineau-TRI
changed the title
EricCousineau-TRI
force-pushed
the
feature-same-bazelrc
branch
from
0ac5be7
to
f04cf92
Compare
There was a problem hiding this comment.
Reviewable status: 0 of 23 files reviewed, all discussions resolved (waiting on @IanTheEngineer)
a discussion (no related file):
Previously, EricCousineau-TRI (Eric Cousineau) wrote…
Working: This PR currently does two things - try to ensure build flags are the same to help caching, and then ensure test flags are the same to force isolation.
I'm going to split the caching portion off of this, and make this PR only responsible for isolation flags.
Done.
There was a problem hiding this comment.
@adityapande-1995 , the CI failure in this PR claims to be due to running out of space. I know you've been looking into this on other PR's. Do you have any insight on solutions?
Reviewed 18 of 19 files at r2, 5 of 5 files at r3, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @EricCousineau-TRI)
bazel_ros2_rules/ros2/resources/bazel_ros_env/bazel_ros_env.py line 1 at r3 (raw file):
# TODO(eric.cousineau): Move RMW + ROS isolation to a location accessible by
BTW: The TODO is perfectly fine here, but to keep track a a higher level an issue would be helpful.
Move drake_ros...bazel_ros_testing to bazel_ros2_rules...bazel_ros_env
EricCousineau-TRI
force-pushed
the
feature-same-bazelrc
branch
from
f04cf92
to
dfed0a8
Compare
There was a problem hiding this comment.
Thanks!
the CI failure in this PR claims to be due to running out of space
Aye, mentioned in #247 (comment)
My plan is to run testing locally, then merge it.
Reviewable status: 22 of 23 files reviewed, all discussions resolved (waiting on @IanTheEngineer)
bazel_ros2_rules/ros2/resources/bazel_ros_env/bazel_ros_env.py line 1 at r3 (raw file):
Previously, IanTheEngineer (Ian McMahon) wrote…
BTW: The TODO is perfectly fine here, but to keep track a a higher level an issue would be helpful.
Done.
|
Local testing passed, merging forward. |
As noticed in #295 (review)
This change is