Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: attachment and avatar size in messages #922

Merged
merged 5 commits into from
Jan 27, 2025

Conversation

abirc8010
Copy link
Contributor

@abirc8010 abirc8010 commented Jan 18, 2025

Brief Title

Fixed responsiveness for attachments and avatar sizes in messages.

Acceptance Criteria fulfillment

  • Adjusted avatar size using window.matchMedia for responsive behavior.
  • Added responsive padding in the message styles for smaller screen widths
  • Updated attachment display styles to ensure consistent responsiveness and prevent overflowing for smaller screens.

Fixes #908

Video/Screenshots

Screencast.from.2025-01-19.01-16-00.webm

PR Test Details

Note: The PR will be ready for live testing at https://rocketchat.github.io/EmbeddedChat/pulls/pr-922 after approval. Contributors are requested to replace <pr_number> with the actual PR number.

@Spiral-Memory
Copy link
Collaborator

Hi @abirc8010
Thanks for the PR

Around 20 second, in the video, the message toolbox is going outside for a small range, Can you fix that too ?

image

@Spiral-Memory Spiral-Memory added the nudge minor tweaks suggested label Jan 27, 2025
@abirc8010
Copy link
Contributor Author

Hey @Spiral-Memory all the chat formatters UI issues can be fixed by #693

@Spiral-Memory
Copy link
Collaborator

Okay got it thanks

@Spiral-Memory Spiral-Memory added testing and removed nudge minor tweaks suggested labels Jan 27, 2025
Copy link
Collaborator

@Spiral-Memory Spiral-Memory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @abirc8010

@Spiral-Memory Spiral-Memory merged commit 93198dc into RocketChat:develop Jan 27, 2025
3 checks passed
github-actions bot added a commit that referenced this pull request Jan 27, 2025
@Spiral-Memory Spiral-Memory added the chore a subtle fix label Jan 30, 2025
@Spiral-Memory Spiral-Memory changed the title Fix: attachment and avatar size in messages chore: attachment and avatar size in messages Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore a subtle fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Messages UI Not Scaling Properly on Smaller Screens
2 participants