Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/dark mode #54

Merged
merged 12 commits into from
Dec 20, 2023
Merged

Feature/dark mode #54

merged 12 commits into from
Dec 20, 2023

Conversation

izm20
Copy link

@izm20 izm20 commented Dec 15, 2023

  • Move the StyleDictionary config to a styleDictionary entry in the design tokens config
  • Add support for dark mode in the CSS variables with the darkMode and the darkModeStyleDictionary entries in the
    design tokens config
  • Remove figmaThemes

Copy link

changeset-bot bot commented Dec 15, 2023

🦋 Changeset detected

Latest commit: d6928d0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@runroom/design-tokens Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Dec 15, 2023

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements
73.44% (-4.36% 🔻)
481/655
🟡 Branches
60.27% (-4.16% 🔻)
135/224
🟡 Functions
73.8% (-5.06% 🔻)
138/187
🟡 Lines
72.62% (-4.37% 🔻)
443/610
Show new covered files 🐣
St.
File Statements Branches Functions Lines
🔴
... / styleDictionary.ts
25% 16.67% 7.69% 25.49%
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🟡 tokens/Colors.ts
68.42% (-27.41% 🔻)
61.54% (-16.24% 🔻)
70% (-30% 🔻)
68.57% (-26.88% 🔻)

Test suite run success

82 tests passing in 4 suites.

Report generated by 🧪jest coverage report action from d6928d0

Base automatically changed from feature/style-dictionary to main December 20, 2023 14:32
@izm20 izm20 merged commit 1b7ed3b into main Dec 20, 2023
3 checks passed
@izm20 izm20 deleted the feature/dark-mode branch December 20, 2023 14:48
@github-actions github-actions bot mentioned this pull request Dec 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant