-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add filtering support and subcrate #148
base: master
Are you sure you want to change the base?
Conversation
…res flags up crate chain
Once again, great stuff @linclelinkpart5 - thanks for the PR! I wonder if we should allow for alternatives to the Before we merge, could you update the action in Edit: Also if you could update the CHANGELOG that would be very helpful. |
@mitchmindtree Certainly! I'll go ahead and make the change to |
As for the general concept of filtering, I need to do a bit more research to see what other kinds of useful types of digital filters there are. As far as I was able to tell, using biquads was the magic ticket: they're flexible enough to do single pole (or what I guess would be called "uniquad", but I've never come across that term) filters, and any filters of higher orders can be represented as a series of biquad filters. In fact, it's recommended! A feature that I'd love to tackle once this lands in |
Are there any updates on this? Looks good 👀 |
Closes #145
Adds a new subcrate
dasp_filter
, which includesCoefficients
andBiquad
types. This crate uses the same feature gating as the other crates indasp
.In addition, similar to how
envelope
is a subfeature indasp_signal
, I also addedfilter
as a subfeature. This involves adding feature flags for thedasp_signal
subcrate, plus an extension trait (SignalFilter
) and iterator type (FilteredSignal
) indasp_signal
, both of which are feature-gated.