Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove nightly requirement for no_std #184

Merged
merged 1 commit into from
Nov 7, 2024

Conversation

Dicklessgreat
Copy link
Contributor

I think it is overkill that all dasp libraries require Nightly just because there is no sqrt() function implementation for floating point types in no_std environment.
In my case, I just wanted to use the Frame type, but compiler requires nightly.
I did the same implementation to the sqrt() method as micromath or this one that it was based on.
https://github.com/tarcieri/micromath/blob/6de9df6943b6f06c087ab43ddc3523a379e00369/src/float/sqrt.rs#L13
https://bits.stephan-brumme.com/squareRoot.html
Adding micro_math to dependencies is a good idea, but if you think it is overkill, how about what I wrote?
What I wrote is just a suggestion, I believe the issue is that dasp requires Nightly if you try to use it in no_std.

@est31 est31 merged commit cd8d893 into RustAudio:master Nov 7, 2024
4 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants