fix(app-config-writer): wrong prerequisites check in convert preview-config #2922
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 0907b8e The changes in this PR will be included in the next version bump. This PR includes changesets to release 41 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The new sonar issue seems to be a false positive because casting to |
…eview-prerequisites' into fix/app-config-writer/convert-preview-prerequisites
…s and use in app-config-writer
Co-authored-by: Klaus Keller <[email protected]>
…eview-prerequisites' into fix/app-config-writer/convert-preview-prerequisites
|
@Klaus-Keller ...and yes w.r.t. the failing unit test I might need your help. The cards-editor-middleware unit test fails because https://cloud.nx.app/runs/OEWcAt6JIL/task/%40sap-ux%2Fcards-editor-middleware%3Atest |
…eview-prerequisites' into fix/app-config-writer/convert-preview-prerequisites
heimwege
added
cap-config-writer
Klaus-Keller
approved these changes
Mar 10, 2025
There was a problem hiding this comment.
Thanks @heimwege!
- code changes and moving of CDS check look good
- all my comments have been addressed
- changeset exists
- code coverage is good
- visual review, no manual testing done
Approved from my side.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cds-plugin-ui5is currently being searched inpackage.jsonof the app to be converted but must be searched for in CAP rootpackage.json.This fix currently leads to an exception in project-access checkFilesInSrvFolder in case the CAP srv folder contains sub folders. (fixed in #2923) ✅
Depends on #2926 being merged ✅