Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cf-deploy-sub-gen): handle flow when loaded as sub-gen #2956

Merged
merged 4 commits into from
Feb 25, 2025
Merged

fix(cf-deploy-sub-gen): handle flow when loaded as sub-gen #2956

merged 4 commits into from
Feb 25, 2025

Conversation

longieirl
Copy link
Contributor

@longieirl longieirl commented Feb 24, 2025 •
edited
Loading

Fix for #2821

  • found when testing locally in tools-suite
  • init should only be called when run standalone
  • add tests to cover this change

@longieirl longieirl self-assigned this Feb 24, 2025
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Feb 24, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: 7303491

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sap-ux/cf-deploy-config-sub-generator Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@longieirl longieirl marked this pull request as ready for review February 24, 2025 15:59
@longieirl longieirl changed the title fix(cf-deploy-sub-gen): cleeanup code to handle when loaded as subgen… fix(cf-deploy-sub-gen): cleeanup code to handle when loaded as sub Feb 24, 2025
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
91.7% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@longieirl longieirl changed the title fix(cf-deploy-sub-gen): cleeanup code to handle when loaded as sub fix(cf-deploy-sub-gen): cleanup code to handle when loaded as sub Feb 24, 2025
@longieirl longieirl requested a review from cianmSAP February 25, 2025 10:47
@longieirl longieirl changed the title fix(cf-deploy-sub-gen): cleanup code to handle when loaded as sub fix(cf-deploy-sub-gen): handle flow when loaded as sub-gen Feb 25, 2025
IainSAP
IainSAP approved these changes Feb 25, 2025
View reviewed changes
Copy link
Contributor

@IainSAP IainSAP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @longieirl

  • Updates are clear, separate function
  • Tests to cover
  • Not tested locally

cianmSAP
cianmSAP approved these changes Feb 25, 2025
View reviewed changes
Copy link
Contributor

@cianmSAP cianmSAP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updates look good
Have not tested

@longieirl longieirl merged commit a92b715 into main Feb 25, 2025
16 checks passed
@longieirl longieirl deleted the 2821/fix-issues branch February 25, 2025 13:21
@longieirl longieirl restored the 2821/fix-issues branch February 26, 2025 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IainSAP IainSAP IainSAP approved these changes

@cianmSAP cianmSAP cianmSAP approved these changes

Assignees

@longieirl longieirl

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@longieirl @IainSAP @cianmSAP