Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(odata-service-inq): handle exception if user is missing cf privileges to create CF destinations #2963

Merged
merged 8 commits into from
Feb 28, 2025

Conversation

longieirl
Copy link
Contributor

Fix for #2962

@longieirl longieirl self-assigned this Feb 26, 2025
Copy link

changeset-bot bot commented Feb 26, 2025

🦋 Changeset detected

Latest commit: 74c389d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sap-ux/odata-service-inquirer Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@longieirl longieirl requested a review from IainSAP February 26, 2025 16:51
@longieirl longieirl marked this pull request as ready for review February 27, 2025 09:25
Copy link
Contributor

@IainSAP IainSAP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @longieirl

  • Appropriate fix for uncaught error
  • Test added to cover
  • Not tested locally

Copy link
Member

@kjose90 kjose90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

try catch added for handling exceptions.
Changeset and tests ✅
Thanks

@longieirl longieirl merged commit 0ff192b into main Feb 28, 2025
16 checks passed
@longieirl longieirl deleted the 2962/handle-create-destination-exception branch February 28, 2025 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants