Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] make install a command generator #3535

Closed
wants to merge 1 commit into from
Closed

[WIP] make install a command generator #3535

wants to merge 1 commit into from

Conversation

chasinglogic
Copy link
Contributor

@chasinglogic chasinglogic commented Jan 24, 2020

This is an idea we've had for a long time. It allows for very interesting use cases like adding --reflink=auto for faster installs on FS that support it, using symlinks for installs for developer builds, and perhaps the most interesting:

env.Install(
    target="$DEPLOY_DIR",
    source=myapp,
)

env['COPY'] = 'rsync'
env['COPYFLAGS'] = ['-avz']
python ./buildscripts/scons.py DEPLOY_DIR="dev-server:/app/deploy" deploy

Contributor Checklist:

  • I have created a new test or updated the unit tests to cover the new/changed functionality.
  • I have updated master/src/CHANGES.txt directory (and read the README.txt in that directory)
  • I have updated the appropriate documentation

@bdbaddog
Copy link
Contributor

bdbaddog commented Feb 4, 2020

I'd like to see the variables all be INSTALL_ or INSTALL* instead of COPY* affecting Install().

Any idea if this impacts performance? (I'd expect it to be faster and not subject to GIL..)

@bdbaddog
Copy link
Contributor

bdbaddog commented Feb 4, 2020

But hold off on changes to name. Let's catch up on discord tomorrow.

@bdbaddog
Copy link
Contributor

bdbaddog commented Feb 4, 2020

Also.. doc changes will be needed.

bdbaddog added a commit to bdbaddog/scons that referenced this pull request Mar 2, 2020
…s() logic to use a generator to create the command. Break out variables for INSTALL{FILE,DIR}COPY[FLAGS] as a different command is run by default for copying files and directories. Some doc updates.
@bdbaddog
Copy link
Contributor

bdbaddog commented Mar 3, 2020

Closing this as work moved to PR #3573

@bdbaddog bdbaddog closed this Mar 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants