Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apply naming convention to people filenames #207

Merged

Conversation

solon
Copy link
Member

@solon solon commented Jun 21, 2019

  • Applies a naming convention to each person's bio and profile image filename:
    • kebab-case (all lowercase with hyphens)
    • replace accented characters with non-accented versions
  • By adopting this convention we can use the Jekyll page.id / person.id variable when referencing the image file, and we will avoid issues with different filesystems and Git.
    • We are still free to use special characters to correctly spell people's names in the page title and content—just not in the filename.
  • Updates the people and person layouts to use the person.id / page.id variable
  • Adds redirects where the person's URL changed in two cases
  • Fixes Issues with two student profiles #139

Note: this PR, if merged or squashed into a single commit, will cause issues for users with case-insensitive filesystems (which is the default on mac OS). For that reason, it should be merged using the Rebase and merge option which will add the individual commits from this PR to the master branch.

image

@solon solon changed the title apply naming convention to people filenames (fix #139) apply naming convention to people filenames Jun 21, 2019
@solon solon requested review from tchoi8, poohlaga and rileyjshaw June 21, 2019 00:33
@rileyjshaw
Copy link
Member

You rock. Thanks so much for pointing out the issue with case-insensitive filesystems before I messed it up, and for providing a solution. I know a lot of people have come across these error messages, and will be happy to see them gone.

One question: it looks like Diana Sánchez and Guillermo Montecinos Peña may have had their info deleted and not re-added. Am I missing something?

@solon
Copy link
Member Author

solon commented Jun 21, 2019

One question: it looks like Diana Sánchez and Guillermo Montecinos Peña may have had their info deleted and not re-added. Am I missing something?

For some reason, there were two copies of each of their bios in the repository. This PR removes the duplicates and renames the remaining copies.

image

@rileyjshaw
Copy link
Member

Oh, interesting! Alright, thanks for clearing that up.

@rileyjshaw rileyjshaw merged commit fc11766 into SFPC:master Jun 21, 2019
@solon solon deleted the apply-naming-convention-to-people-filenames branch June 21, 2019 01:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issues with two student profiles
2 participants