add programmatic and manual alt tags #241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for sfpc ready! Built with commit 3040668 |
Inkering
changed the title
Modified the slider parsing to be flexible for either image source only use or for use of image source AND an alt tag. This way, we can add alt text to slides and pages progressively without breaking layouts along the way.
I added alt text to every instance I was able to find in a grep search for "slides:"
|
I added a short snippet of code to enable adding alt tags to image carousel slides in markdown. The old slide specification still works, and then this is a progressively available option which is easy to use. |
|
solon
reviewed
Oct 5, 2020
solon
reviewed
Oct 5, 2020
Co-authored-by: Brian Solon <[email protected]>
Co-authored-by: Brian Solon <[email protected]>
solon
reviewed
Oct 5, 2020
| @@ -3,7 +3,7 @@ title: Participate 2014 | |||
| layout: default | |||
| --- | |||
|
|
|||
| <img src="../img/SPCPicket.jpg" width="640"> | |||
| <img src="../img/SPCPicket.jpg" alt="people holding signs with text School for Poetic Computationon them" width="640"> | |||
There was a problem hiding this comment.
Suggested change
| <img src="../img/SPCPicket.jpg" alt="people holding signs with text School for Poetic Computationon them" width="640"> | |
| <img src="../img/SPCPicket.jpg" alt="people holding signs with text School for Poetic Computation on them" width="640"> |
solon
reviewed
Oct 5, 2020
|  | ||
|  | ||
|  | ||
|  |
There was a problem hiding this comment.
Suggested change
|  | |
|  |
solon
reviewed
Oct 5, 2020
|  | ||
|  | ||
|  | ||
|  |
There was a problem hiding this comment.
Suggested change
|  | |
|  |
solon
reviewed
Oct 5, 2020
|
|
||
| [CW&T](https://cwandt.com/) is the art and design practice of Che-Wei Wang & Taylor Levy. | ||
|
|
||
| Che-Wei Wang [pron. sey-wey] is an artist, designer & architect with expertise in computational and generative design, fabrication technologies, electronics, CNC machining, and metal manufacturing. The results range from architecture & sculpture to interactive installations & mobile apps. He is the winner of the 2003 SOM fellowship and the Young Alumni Achievement Award from Pratt Institute. Che-Wei has taught courses on design, time, creative computing, and inflatables, at various institutions. He is an alumnus of MIT Media Lab, ITP at NYU, and Pratt Institute. | ||
|
|
||
| Taylor Levy [pron. tey-ler] is an artist & designer with a penchant for taking things apart, understanding how they work, and then putting them back together in a way that exposes their inner workings.The results take on a variety of forms from low-tech electronic sculpture to high-tech software & other executions. She has work on view at The Leonardo Museum of Science and Technology and was a resident at Fabrica Interactive in Treviso, Italy. She is an alumna of MIT Media Lab, ITP at NYU, and Vassar College. | ||
|
|
||
|  | ||
|  |
There was a problem hiding this comment.
Suggested change
|  | |
|  |
solon
reviewed
Oct 5, 2020
| @@ -81,16 +94,16 @@ This class is not right for you if: | |||
| - You are interested in a more skills based, less theoretical approach to learning creative code | |||
| - You are not interested in research or engaging with artworks from the past | |||
|
|
|||
|  | |||
|  | |||
There was a problem hiding this comment.
Suggested change
|  | |
|  |
solon
reviewed
Oct 5, 2020
| - image: "/static/img/participate/fall15-sarah.jpg" | ||
| alt: "Sarah talking to a person in front of hung artwork" | ||
| - image: "/static/img/participate/fall16-katrina.jpg" | ||
| alt: "Katrina making hearing motion (hand cuped to ear) in front of welcome to the chatter box projection" |
There was a problem hiding this comment.
Suggested change
| alt: "Katrina making hearing motion (hand cuped to ear) in front of welcome to the chatter box projection" | |
| alt: "Katrina making hearing motion (hand cupped to ear) in front of welcome to the chatter box projection" |
solon
reviewed
Oct 5, 2020
| - "/static/img/participate/poeticsciencefair.jpg" | ||
| - "/static/img/participate/notebook.jpg" | ||
| - image: "/static/img/participate/SFPC2-weekSummer.jpg" | ||
| alt: "SFPC 2 week summer session text photoshopped onto nytimes front page" |
There was a problem hiding this comment.
Suggested change
| alt: "SFPC 2 week summer session text photoshopped onto nytimes front page" | |
| alt: "SFPC 2 week summer session text photoshopped onto NY Times front page" |
solon
reviewed
Oct 5, 2020
| - image: "/static/img/participate/flower.jpg" | ||
| alt: "books next to flowers, the books are conditional design workbook, speaking code, and the art of the art assignment" | ||
| - image: "/static/img/participate/door.jpg" | ||
| alt: "sfpc door with signs and sticks all over it, its a pull and push door" |
There was a problem hiding this comment.
Suggested change
| alt: "sfpc door with signs and sticks all over it, its a pull and push door" | |
| alt: "sfpc door with signs and sticks all over it, it's a pull and push door" |
solon
reviewed
Oct 5, 2020
| @@ -149,7 +149,7 @@ <h1 class="title">Guhong Min</h1> | |||
| <div class="container"> | |||
| <h1 class="title">Hélène Martin</h1> | |||
| <figure class="image"> | |||
| <img src="assets/images/helene.gif" alt="Hélène Martin"> | |||
| <img src="assets/images/helene.gif" alt="Hélène Martin's banner, representation of the statue of liberty with red led attached"> | |||
There was a problem hiding this comment.
Suggested change
| <img src="assets/images/helene.gif" alt="Hélène Martin's banner, representation of the statue of liberty with red led attached"> | |
| <img src="assets/images/helene.gif" alt="Hélène Martin's banner, representation of the statue of liberty with red LED attached"> |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
additions of alt image information both manually and programmatically. Resolves #233