-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pydantification #155
Pydantification #155
Conversation
I've looked through this and I think the new approach is excellent. @JGoldstone can you confirm that the outputs - i.e. build/schema.json and the build/examples/* are identical to the published ones? |
Will check the match one more time. Almost 100% sure the examples match; will recheck schema, but I don't think I would have said it's ready without that matching as well. |
To go through those verbally (and they all have to do with the new-ish PTP stuff):
|
If you're good with those, I will hand-update the reference schema json against which the generated schema is compared to be as shown above, then check in that and the fix to add |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The minor schema changes LGTM.
…ema_regression.py and test_example_regression.py as those depend on the build products existing.
This PR converts
camdkit
to use Pydantic. As compared to the previous PR attempting to do the same: