🐛 Re-added support for older QR Codes, improved QR scanning logic and bumped mobile version #1195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng validation (before camera is closed)
vladislav-kir
requested changes
Feb 4, 2025
Bump up android:versionCode
vladislav-kir
approved these changes
Feb 4, 2025
vladislav-kir
deleted the
1181-fix-qr-code-scanning-issue-in-rewards-mobile-app
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✏️ #1181
✏️ Improved QR code scanning. Not only it supports old QR codes (with just base64 that have "ach:", "rwd:", etc. in the body) but also now checks which of the visible QR codes are valid. This means that if there is 1 SSW Rewards QR Code and 9 random QR Codes, it will always pick SSW Rewards QR Code.
✏️ No.