Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XS✔ ◾ Improvements to rule on sharing secrets #9569

Merged
merged 2 commits into from
Nov 11, 2024
Merged

Conversation

tiagov8
Copy link
Member

@tiagov8 tiagov8 commented Nov 8, 2024

cc @adamcogan @jeoffreyfischer

  1. What triggered this change? (PBI link, Email Subject, conversation + reason, etc)

CTF

  1. What was changed?

Formatting, wording, links, and more

  1. Did you do pair or mob programming (list names)?

no

Copy link
Contributor

github-actions bot commented Nov 8, 2024

PR Metrics

Thanks for keeping your pull request small.
Thanks for adding tests.

Lines
Product Code -
Test Code -
Subtotal -
Ignored Code 29
Total 29

Metrics computed by PR Metrics. Add it to your Azure DevOps and GitHub PRs!

@github-actions github-actions bot changed the title Improvements to rule on sharing secrets XS✔ ◾ Improvements to rule on sharing secrets Nov 8, 2024
Copy link
Contributor

github-actions bot commented Nov 8, 2024

Hi @tiagov8,

We found some markdown suggestions for your Pull Request:

File Error Rule
rules/share-your-developer-secrets-securely/rule.md Line 42: should have alternate text (alt text) Rule MD045
rules/share-your-developer-secrets-securely/rule.md Line 57: should have alternate text (alt text) Rule MD045
rules/share-your-developer-secrets-securely/rule.md Line 76: should have alternate text (alt text) Rule MD045
rules/share-your-developer-secrets-securely/rule.md Line 100: should have alternate text (alt text) Rule MD045
rules/share-your-developer-secrets-securely/rule.md Line 149: should have alternate text (alt text) Rule MD045

Please review and update your Markdown files accordingly.

@github-actions github-actions bot added Age: 🐣 - Young About 4 hours old Age: 🐥 - Adolescent About 8 hours old Age: 🐤 - Mature About 16 hours old Age: 🐓 - Old About 32 hours old Age: 🍗 - Ancient About 64 hours old 🔥 Merge Debt This PR contains merge debt, see https://www.ssw.com.au/rules/merge-debt/ and removed Age: 🥚 - New About 2 hours old Age: 🐣 - Young About 4 hours old Age: 🐥 - Adolescent About 8 hours old Age: 🐤 - Mature About 16 hours old Age: 🐓 - Old About 32 hours old labels Nov 9, 2024
Copy link
Contributor

Howzit @tiagov8,

This PR has been here a while.

Did you know you should avoid merge debt?

  1. Please action (e.g. get a review) and merge or close

Thanks!

Copy link
Member

@jeoffreyfischer jeoffreyfischer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks for reviewing the rule :)

@github-actions github-actions bot added Age: 🦖 - Extinct About 128 hours old and removed Age: 🍗 - Ancient About 64 hours old labels Nov 11, 2024
@tiagov8 tiagov8 merged commit 568b282 into main Nov 11, 2024
@tiagov8 tiagov8 deleted the tiagov8-patch-19 branch November 11, 2024 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Age: 🦖 - Extinct About 128 hours old 🔥 Merge Debt This PR contains merge debt, see https://www.ssw.com.au/rules/merge-debt/
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants