Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Internal/io/std renaming #703

Merged
merged 12 commits into from
Feb 28, 2025
Merged

Internal/io/std renaming #703

merged 12 commits into from
Feb 28, 2025

Conversation

SSoelvsten
Copy link
Owner

@SSoelvsten SSoelvsten commented Feb 27, 2025

This way we have less TPIE and more STD. This will make switching to another
backend much easier
This better aligns with other 'external-only' regions that are still included
This can be used as a sanity-check if/when an alternative to TPIE is used
@SSoelvsten SSoelvsten added 🔥 bug Something isn't working ✨ code quality Uncle Bob would be proud 📁 internal This is where the ✨magic✨happens labels Feb 27, 2025
@SSoelvsten SSoelvsten added this to the v2.0 : API Revamp milestone Feb 27, 2025
@SSoelvsten SSoelvsten self-assigned this Feb 27, 2025
Copy link

codecov bot commented Feb 27, 2025

Codecov Report

Attention: Patch coverage is 97.84736% with 11 lines in your changes missing coverage. Please review.

Project coverage is 97.275%. Comparing base (1aa125e) to head (a7812da).
Report is 13 commits behind head on main.

Files with missing lines Patch % Lines
src/adiar/internal/data_structures/sorter.h 73.333% 8 Missing ⚠️
...nternal/data_structures/levelized_priority_queue.h 71.429% 2 Missing ⚠️
src/adiar/internal/io/node_ofstream.h 96.154% 1 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##              main      #703       +/-   ##
=============================================
- Coverage   98.038%   97.275%   -0.764%     
=============================================
  Files           93        95        +2     
  Lines         7137      7265      +128     
=============================================
+ Hits          6997      7067       +70     
- Misses         140       198       +58     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Feb 27, 2025

🟡 Regression Test (12-Queens)

'ssoelvsten/adiar/internal/io/std_renaming' is a change in performance of 0.45% (stdev: 0.31%).

... origin/main ssoelvsten/adiar/internal/io/std_renaming
Mean 11615.67 11563.33
Standard Deviation 36.30 19.86

Number of samples: 3

Copy link

github-actions bot commented Feb 27, 2025

🟡 Regression Test (Picotrav 'adder')

'ssoelvsten/adiar/internal/io/std_renaming' is a change in performance of 1.12% (stdev: 3.09%).

... origin/main ssoelvsten/adiar/internal/io/std_renaming
Mean 9944.00 9833.00
Standard Deviation 272.24 303.61

Number of samples: 3

This can be used as a sanity-check if/when an alternative to TPIE is used
Copy link

github-actions bot commented Feb 27, 2025

🟡 Regression Test (QBF 'breakthrough_dual/3x6_10_bwnib')

'ssoelvsten/adiar/internal/io/std_renaming' is a change in performance of -0.20% (stdev: 1.09%).

... origin/main ssoelvsten/adiar/internal/io/std_renaming
Mean 5121.33 5131.33
Standard Deviation 11.55 55.75

Number of samples: 3

Copy link

github-actions bot commented Feb 27, 2025

🟢 Regression Test (QBF 'breakthrough/3x4_19_bwnib')

'ssoelvsten/adiar/internal/io/std_renaming' is a change in performance of 0.70% (stdev: 0.29%).

... origin/main ssoelvsten/adiar/internal/io/std_renaming
Mean 21986.00 21831.00
Standard Deviation 63.79 48.54

Number of samples: 3

Copy link

github-actions bot commented Feb 27, 2025

🟡 Regression Test (Picotrav 'arbiter')

'ssoelvsten/adiar/internal/io/std_renaming' is a change in performance of -0.48% (stdev: 0.58%).

... origin/main ssoelvsten/adiar/internal/io/std_renaming
Mean 63077.00 63377.33
Standard Deviation 126.74 368.93

Number of samples: 3

@SSoelvsten SSoelvsten force-pushed the internal/io/std_renaming branch from 0a8bfd7 to a636007 Compare February 27, 2025 16:05
Copy link

github-actions bot commented Feb 27, 2025

🟡 Regression Test (QBF 'httt/4x4_9_tippy_bwnib')

'ssoelvsten/adiar/internal/io/std_renaming' is a change in performance of 2.96% (stdev: 3.31%).

... origin/main ssoelvsten/adiar/internal/io/std_renaming
Mean 9646.33 9360.33
Standard Deviation 319.58 78.01

Number of samples: 3

Copy link

github-actions bot commented Feb 27, 2025

🟡 Regression Test (QBF 'ep_dual/8x8_6_e-8-1_p-2-3_bwnib')

'ssoelvsten/adiar/internal/io/std_renaming' is a change in performance of 0.50% (stdev: 0.79%).

... origin/main ssoelvsten/adiar/internal/io/std_renaming
Mean 5027.33 5002.33
Standard Deviation 21.59 39.63

Number of samples: 3

Copy link

github-actions bot commented Feb 27, 2025

🟢 Regression Test (QBF 'domineering/5x5_13_bwnib')

'ssoelvsten/adiar/internal/io/std_renaming' is a change in performance of 0.55% (stdev: 0.27%).

... origin/main ssoelvsten/adiar/internal/io/std_renaming
Mean 15147.33 15063.33
Standard Deviation 9.45 41.04

Number of samples: 3

Copy link

github-actions bot commented Feb 27, 2025

🟡 Regression Test (QBF 'hex/hein_08_5x5-11_bwnib')

'ssoelvsten/adiar/internal/io/std_renaming' is a change in performance of 0.21% (stdev: 0.15%).

... origin/main ssoelvsten/adiar/internal/io/std_renaming
Mean 16773.67 16737.67
Standard Deviation 16.50 25.03

Number of samples: 3

Copy link

github-actions bot commented Feb 27, 2025

🟡 Regression Test (QBF 'ep/8x8_7_e-8-1_p-3-4_bwnib')

'ssoelvsten/adiar/internal/io/std_renaming' is a change in performance of 0.56% (stdev: 0.39%).

... origin/main ssoelvsten/adiar/internal/io/std_renaming
Mean 29114.33 28950.67
Standard Deviation 114.15 43.88

Number of samples: 3

Copy link

github-actions bot commented Feb 27, 2025

🟡 Regression Test (QBF 'connect4/6x6_11_connect4_bwnib')

'ssoelvsten/adiar/internal/io/std_renaming' is a change in performance of 0.99% (stdev: 0.67%).

... origin/main ssoelvsten/adiar/internal/io/std_renaming
Mean 12048.67 11929.67
Standard Deviation 80.87 67.99

Number of samples: 3

Copy link

github-actions bot commented Feb 27, 2025

🟡 Regression Test (Picotrav 'mem_ctrl')

'ssoelvsten/adiar/internal/io/std_renaming' is a change in performance of -0.30% (stdev: 1.05%).

... origin/main ssoelvsten/adiar/internal/io/std_renaming
Mean 125456.67 125829.67
Standard Deviation 1316.07 48.60

Number of samples: 3

Copy link

github-actions bot commented Feb 27, 2025

🟡 Regression Test (14-Queens)

'ssoelvsten/adiar/internal/io/std_renaming' is a change in performance of -0.21% (stdev: 1.64%).

... origin/main ssoelvsten/adiar/internal/io/std_renaming
Mean 268065.33 268631.67
Standard Deviation 214.39 4417.15

Number of samples: 3

@SSoelvsten SSoelvsten marked this pull request as ready for review February 28, 2025 16:22
@SSoelvsten SSoelvsten merged commit 811884a into main Feb 28, 2025
59 of 60 checks passed
@SSoelvsten SSoelvsten deleted the internal/io/std_renaming branch February 28, 2025 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔥 bug Something isn't working ✨ code quality Uncle Bob would be proud 📁 internal This is where the ✨magic✨happens
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant