Removing definition of inline variable, and modified CIs to use the c…

…orrect option Signed-off-by: Vedant <[email protected]>
STEllAR-GROUP · Apr 12, 2024 · 1a5ec29 · 1a5ec29
1 parent 38b3ff7
commit 1a5ec29
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 2 deletions.
diff --git a/.github/workflows/linux_with_bench_test.yml b/.github/workflows/linux_with_bench_test.yml
@@ -39,3 +39,8 @@ jobs:
       run: |
           cd build
           ./bin/minmax_element_performance_test
+    - name: Test with detailed output
+      shell: bash
+      run: |
+          cd build
+          ./bin/minmax_element_performance_test --detailed_bench
diff --git a/.github/workflows/linux_with_nanobench_test.yml b/.github/workflows/linux_with_nanobench_test.yml
@@ -45,4 +45,4 @@ jobs:
       shell: bash
       run: |
           cd build
-          ./bin/minmax_element_performance_test --hpx:verbose_bench
+          ./bin/minmax_element_performance_test --detailed_bench
diff --git a/libs/core/testing/include/hpx/testing/performance.hpp b/libs/core/testing/include/hpx/testing/performance.hpp
@@ -14,7 +14,7 @@
 #include <string>
 
 namespace hpx::util {
-    HPX_CORE_EXPORT inline bool detailed_ = false;
+    HPX_CORE_EXPORT inline bool detailed_;
     HPX_CORE_EXPORT void perftests_cfg(hpx::program_options::options_description& cmdline);
     HPX_CORE_EXPORT void perftests_init(const hpx::program_options::variables_map& vm);
 #if defined(HPX_HAVE_NANOBENCH)