Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove SVFInstruction to node maps in ICFG #1547

Merged
merged 17 commits into from
Sep 25, 2024
Merged

Conversation

jumormt
Copy link
Contributor

@jumormt jumormt commented Sep 15, 2024

The ultimate goal is to remove these three maps in ICFG:

CSToCallNodeMapTy CSToCallNodeMap; ///< map a callsite to its CallICFGNode
CSToRetNodeMapTy CSToRetNodeMap; ///< map a callsite to its RetICFGNode
InstToBlockNodeMapTy InstToBlockNodeMap; ///< map a basic block to its ICFGNode

I want to migrate them to LLVMModuleset and build mapping from LLVM instruction directly to ICFGNodes. Currently these three maps are still in ICFG class but will be removed after all the migration is done.

Copy link

codecov bot commented Sep 15, 2024

Codecov Report

Attention: Patch coverage is 86.77419% with 41 lines in your changes missing coverage. Please review.

Project coverage is 62.88%. Comparing base (1f3c40d) to head (84bf1d2).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
svf-llvm/lib/SVFIRBuilder.cpp 79.03% 13 Missing ⚠️
svf/lib/DDA/ContextDDA.cpp 0.00% 8 Missing ⚠️
svf-llvm/include/SVF-LLVM/LLVMModule.h 77.77% 4 Missing ⚠️
svf-llvm/lib/LLVMModule.cpp 87.09% 4 Missing ⚠️
svf/lib/AE/Svfexe/AEDetector.cpp 0.00% 2 Missing ⚠️
svf/lib/Graphs/ICFG.cpp 75.00% 2 Missing ⚠️
svf/lib/SABER/SaberSVFGBuilder.cpp 0.00% 2 Missing ⚠️
svf-llvm/include/SVF-LLVM/DCHG.h 0.00% 1 Missing ⚠️
svf-llvm/lib/ICFGBuilder.cpp 98.68% 1 Missing ⚠️
svf/include/Graphs/CDG.h 0.00% 1 Missing ⚠️
... and 3 more
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1547      +/-   ##
==========================================
- Coverage   62.88%   62.88%   -0.01%     
==========================================
  Files         245      245              
  Lines       25687    25681       -6     
  Branches     4491     4505      +14     
==========================================
- Hits        16153    16149       -4     
+ Misses       9534     9532       -2     
Files with missing lines Coverage Δ
svf-llvm/include/SVF-LLVM/ICFGBuilder.h 100.00% <100.00%> (ø)
svf-llvm/include/SVF-LLVM/LLVMUtil.h 82.35% <100.00%> (+1.10%) ⬆️
svf-llvm/include/SVF-LLVM/SVFIRBuilder.h 90.09% <100.00%> (+0.09%) ⬆️
svf-llvm/lib/LLVMLoopAnalysis.cpp 100.00% <100.00%> (ø)
svf-llvm/lib/LLVMUtil.cpp 79.11% <100.00%> (+0.51%) ⬆️
svf-llvm/lib/SVFIRExtAPI.cpp 84.74% <100.00%> (ø)
svf-llvm/lib/SymbolTableBuilder.cpp 89.09% <100.00%> (ø)
svf/include/Graphs/CFLGraph.h 92.00% <100.00%> (ø)
svf/include/Graphs/CHG.h 94.44% <100.00%> (ø)
svf/include/Graphs/CallGraph.h 92.15% <100.00%> (ø)
... and 36 more

... and 1 file with indirect coverage changes

@jumormt jumormt marked this pull request as ready for review September 23, 2024 07:40
@yuleisui yuleisui merged commit 6a54cf4 into SVF-tools:master Sep 25, 2024
5 checks passed
@jumormt jumormt deleted the 9.15 branch September 25, 2024 03:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants