-
Notifications
You must be signed in to change notification settings - Fork 435
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump LLVM from 13.0.0 to 15.0.0 #901
base: master
Are you sure you want to change the base?
Conversation
…sed by assertions in Release mode for some compilers
include/Util/SparseBitVector.h
Outdated
@@ -321,6 +321,7 @@ template <unsigned ElementSize = 128> struct SparseBitVectorElement | |||
if (Bits[i] != 0) | |||
return i * BITWORD_SIZE + countTrailingZeros(Bits[i]); | |||
assert(false && "SBV: find_first: SBV cannot be empty"); | |||
return -1; // Unreachable. Make the compiler happy |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
return -1; = > abort();
include/Util/SparseBitVector.h
Outdated
@@ -334,6 +335,7 @@ template <unsigned ElementSize = 128> struct SparseBitVectorElement | |||
countLeadingZeros(Bits[Idx]) - 1; | |||
} | |||
assert(false && "SBV: find_last: SBV cannot be empty"); | |||
return -1; // Unreachable. Make the compiler happy |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
return -1; = > abort();
if (!SVFModule::pagReadFromTXT()) | ||
{ | ||
assert(!SVFUtil::isa<DummyValVar>(node) && "a dummy node??"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
_unused(node);
lib/Graphs/ConsG.cpp
Outdated
assert(added && "not added??"); | ||
if (!AddrCGEdgeSet.insert(edge).second) | ||
{ | ||
assert(!"new AddrCGEdge not added??"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
_unused(added);
lib/Graphs/ConsG.cpp
Outdated
bool added = directEdgeSet.insert(edge).second; | ||
assert(added && "not added??"); | ||
if (!directEdgeSet.insert(edge).second) { | ||
assert(!"new CopyCGEdge not added??"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see above
lib/Graphs/ConsG.cpp
Outdated
assert(added && "not added??"); | ||
if (!directEdgeSet.insert(edge).second) | ||
{ | ||
assert(!"new NormalGepCGEdge not added??"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see above
lib/Graphs/ConsG.cpp
Outdated
assert(added && "not added??"); | ||
if (!directEdgeSet.insert(edge).second) | ||
{ | ||
assert(!"new VariantGepCGEdge not added??"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see above
lib/Graphs/ConsG.cpp
Outdated
assert(added && "not added??"); | ||
if (!LoadCGEdgeSet.insert(edge).second) | ||
{ | ||
assert(!"new LoadCGEdge not added??"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see above
lib/Graphs/ConsG.cpp
Outdated
assert(added && "not added??"); | ||
if (!StoreCGEdgeSet.insert(edge).second) | ||
{ | ||
assert(!"new StoreCGEdge not added??"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see above
@@ -364,7 +364,8 @@ ICFGEdge* ICFG::getICFGEdge(const ICFGNode* src, const ICFGNode* dst, ICFGEdge:: | |||
ICFGEdge* ICFG::addIntraEdge(ICFGNode* srcNode, ICFGNode* dstNode) | |||
{ | |||
checkIntraEdgeParents(srcNode, dstNode); | |||
if(ICFGEdge* edge = hasIntraICFGEdge(srcNode,dstNode, ICFGEdge::IntraCF)) | |||
ICFGEdge* edge = hasIntraICFGEdge(srcNode, dstNode, ICFGEdge::IntraCF); | |||
if (edge != nullptr) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see above and all below code needs to be revised and remove if
updated accordingly. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #901 +/- ##
==========================================
- Coverage 63.62% 63.57% -0.05%
==========================================
Files 219 219
Lines 22026 20142 -1884
==========================================
- Hits 14014 12806 -1208
+ Misses 8012 7336 -676
|
The current repo should be able to work on top of llvm-15. |
Changes: