-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to allow commas #1023
Update to allow commas #1023
Conversation
Reviewer's Guide by SourceryThis pull request updates several dependencies in Sequence diagram for parsing viewBox attributesequenceDiagram
participant SVGParser
participant String
SVGParser->>String: getAttribute("viewBox")
String-->>SVGParser: viewBoxValue
SVGParser->>SVGParser: split(/[ ,]+/)
SVGParser-->>SVGParser: vbArray
Updated class diagram for SVG parsingclassDiagram
class SVGParser {
- viewBox: string
+ parseViewBox(viewBox: string): number[]
}
SVGParser : + Uses comma or space as delimiter
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @jfhenon - I've reviewed your changes - here's some feedback:
Overall Comments:
- This change introduces a regular expression to split the viewBox attribute, which is a good way to handle both spaces and commas as separators.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
PR description
Checklist
Note that we require UI tests to ensure that the added feature will not be
nixed by some future fix and that there is at least some test-as-documentation
to indicate how the fix or enhancement is expected to behave.
npm test
, ensuring linting passes and that Cypress UI tests keepcoverage to at least the same percent (reflected in the coverage badge
that should be updated after the tests run)
help both for future users and for the PR reviewer.
Summary by Sourcery
Updates the application to allow commas as separators in viewbox and transform attributes, and updates dependencies.
Bug Fixes:
Enhancements: