[SALAD-23966] [SALAD-23964] WebApp - Add aggregate data type #1269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Maks19
changed the title
rners01
reviewed
Jan 30, 2025
packages/web-app/src/modules/earn-views/components/EarningHistory/utils.ts
Outdated
Show resolved
Hide resolved
rners01
reviewed
Jan 30, 2025
packages/web-app/src/modules/earn-views/components/EarningHistory/EarningHistory.tsx
Outdated
Show resolved
Hide resolved
added 2 commits
January 30, 2025 14:32
vitto-moz
requested changes
Jan 30, 2025
| @@ -69,43 +65,103 @@ interface Props extends WithStyles<typeof styles> { | |||
|
|
|||
| const EarningHistoryRaw = ({ classes, viewLast24Hours, viewLast7Days, viewLast30Days }: Props) => { | |||
There was a problem hiding this comment.
filename is EarningHistory.tsx, but we keep EarningHistoryRaw component here, let's make naming aligned
packages/web-app/src/modules/earn-views/components/EarningLineChart/EarningLineChart.tsx
Outdated
Show resolved
Hide resolved
vitto-moz
requested changes
Feb 5, 2025
packages/web-app/src/modules/earn-views/components/EarningLineChart/EarningLineChart.tsx
Outdated
Show resolved
Hide resolved
added 2 commits
February 5, 2025 16:13
vitto-moz
previously approved these changes
Feb 6, 2025
| }, | ||
| ] | ||
|
|
||
| const machineEarnings = isAggregateView ? aggregateMachineEarnings : individualMachineEarnings | ||
|
|
||
| const withMachinesData = machines !== null |
There was a problem hiding this comment.
Suggested change
| const withMachinesData = machines !== null | |
| const withMachines = machines !== null |
rners01
reviewed
Feb 7, 2025
Comment on lines
14
to
18
| earningsPerMachine: store.balance.earningsPerMachine, | ||
| machines: store.balance.machines, | ||
| daysShowing: store.balance.getDaysShowingEarnings, | ||
| fetchEarningsPerMachine: store.balance.fetchEarningsPerMachine, | ||
| ...props, |
There was a problem hiding this comment.
to not rewrite
Suggested change
| earningsPerMachine: store.balance.earningsPerMachine, | |
| machines: store.balance.machines, | |
| daysShowing: store.balance.getDaysShowingEarnings, | |
| fetchEarningsPerMachine: store.balance.fetchEarningsPerMachine, | |
| ...props, | |
| ...props, | |
| earningsPerMachine: store.balance.earningsPerMachine, | |
| machines: store.balance.machines, | |
| daysShowing: store.balance.getDaysShowingEarnings, | |
| fetchEarningsPerMachine: store.balance.fetchEarningsPerMachine,``` |
rners01
reviewed
Feb 7, 2025
| }, [earningsPerMachine, isAggregateView]) | ||
|
|
||
| useEffect(() => { | ||
| if (Object.values(machineOptions).length > 10) { |
There was a problem hiding this comment.
why specifically 10?
worth moving to the const with explanatory naming?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: Add aggregate data type