[SALAD-23962] Add machine table dropdown menu #1270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
rners01
commented
Jan 30, 2025
rners01
commented
rners01
force-pushed
the
add-machine-table-dropdown-menu
branch
from
7a41318 to
a302d8d
Compare
Maks19
reviewed
Jan 30, 2025
| <FontAwesomeIcon icon={faList} /> | ||
| <Dropdown | ||
| control={<FontAwesomeIcon size="xl" icon={faList} />} | ||
| options={[ |
There was a problem hiding this comment.
Let's move options in separate constant
| @@ -108,7 +109,28 @@ const _AllMachines = ({ classes }: Props) => { | |||
| const getTitles = () => { | |||
| return [ | |||
| <div className={(classes.tableHeaderCell, classes.tableCellCentered)}> | |||
| <FontAwesomeIcon icon={faList} /> | |||
| <Dropdown | |||
There was a problem hiding this comment.
It didn't select items. Will this functionality be added in the following PR?
|
Dropdown options are aligned left on design |
|
rners01
force-pushed
the
add-machine-table-dropdown-menu
branch
2 times, most recently
from
0b192bd to
eb5e222
Compare
vitto-moz
requested changes
Feb 5, 2025
Comment on lines
+120
to
+134
| const beginningIndex = (currentPageNumber - 1) * itemsPerPageAmount | ||
| const endingIndex = currentPageNumber * itemsPerPageAmount | ||
| const machinesToSelect = generatedMockedMachines | ||
| .slice(beginningIndex, endingIndex) | ||
| .reduce((acc, machine) => ({ ...acc, [machine.id]: true }), {}) |
There was a problem hiding this comment.
let's keep it completely aligned with usePagination() hook values.
Suggested change
| const beginningIndex = (currentPageNumber - 1) * itemsPerPageAmount | |
| const endingIndex = currentPageNumber * itemsPerPageAmount | |
| const machinesToSelect = generatedMockedMachines | |
| .slice(beginningIndex, endingIndex) | |
| .reduce((acc, machine) => ({ ...acc, [machine.id]: true }), {}) | |
| const machinesToSelect = generatedMockedMachines | |
| .slice(lowestItemNumberOnPage - 1, highestItemNumberOnPage) | |
| .reduce((acc, machine) => ({ ...acc, [machine.id]: true }), {}) |
Comment on lines
140
to
152
| const beginningIndex = (currentPageNumber - 1) * itemsPerPageAmount | ||
| const endingIndex = currentPageNumber * itemsPerPageAmount | ||
| const machinesToDeselect = generatedMockedMachines | ||
| .slice(beginningIndex, endingIndex) | ||
| .reduce((acc, machine) => ({ ...acc, [machine.id]: false }), {}) |
There was a problem hiding this comment.
let's keep it completely aligned with usePagination() hook values.
Suggested change
| const beginningIndex = (currentPageNumber - 1) * itemsPerPageAmount | |
| const endingIndex = currentPageNumber * itemsPerPageAmount | |
| const machinesToDeselect = generatedMockedMachines | |
| .slice(beginningIndex, endingIndex) | |
| .reduce((acc, machine) => ({ ...acc, [machine.id]: false }), {}) | |
| const machinesToDeselect = generatedMockedMachines | |
| .slice(lowestItemNumberOnPage - 1, highestItemNumberOnPage) | |
| .reduce((acc, machine) => ({ ...acc, [machine.id]: false }), {}) |
rners01
force-pushed
the
add-machine-table-dropdown-menu
branch
from
eb5e222 to
8bcbc3c
Compare
rners01
force-pushed
the
add-machine-table-dropdown-menu
branch
from
8bcbc3c to
ad570be
Compare
vitto-moz
reviewed
Feb 7, 2025
| customStyles?: DropdownStylesConfig | ||
| options?: DropdownOption[] | ||
| value?: string | ||
| isSearchable?: boolean |
There was a problem hiding this comment.
why do we need this functionality?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.