Merge feature/242 into feature/242__use-configured-payment-methods #7123
+9,781
−4,813
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![salesforce-org-metaci[bot]](https://avatars.githubusercontent.com/u/42554011?s=60&v=4){kind=small}
salesforce-org-metaci
bot
requested review from
davidjray
and removed request for
a team
…PatchFix Fix for Pause Request to use PATCH on Updates
…ftEntryController-unit-tests Add new gateway assignment unit tests.
…PatchFix Added logic to fix pause patch calls
…lError Add back missing custom labels causing beta upload failure
… created through the UI
…erRefundTests Updating our refund logic to work with negative payments and no Debit Type
…ization 242 NPSP localized labels
…ization NPSP Localization
Fixed incorrect internal matches with BDI matching when using the 'Contact Duplicate Rules' (aka Duplicate Management) option. Essentially if you had two Data Import records with any one of the 4 pieces of contact information used for matching (first name, last name, email, phone) matching, then it would match the two records together incorrectly and only create one new contact. It should only match internally like that if all the pieces of contact information match. The cause of the issue was that because the Contact matching rule name didn't include the name of any of the fields used for matching, it was creating a key for matching for each field with just the field populated and all others blank. This meant that if any of these contact fields matched, the whole contact would be matched (which is very problematic for things like first name). The fix was to basically make sure that if Duplicate Management was enabled, then it should never include a blank value unless the contact field was actually blank. Also updated the test class to test the partial contact match scenario and the exact internal duplicate match scenario. Also added tests for non-dry run scenarios.
…MgmtInternalMatching W-12250612 - Fixed issue with BDI matching when using Dupe Mgmt
…s-not-updated-ge-batch-process W-15110724 - 250__fields-not-updated-ge-batch-process
'Upgrade process complete' heading is marked with a heading tag <h4> to overcome accessibility issue.
'Data Migration Run' was only styled to look like headings but wasn’t marked as such, hence added h2 heading tag explicitly.
…structure. In RD2_EnablementDelegate.cmp elements are reformed to maintain consistency and proper HTML structure.
To ensure that focus moves to new content when it updates, changes has been added to the RD2_EnablementDelegateController.js file for the Validate and Run Migration buttons.
…7427-avoid-use-of-implicit-headings w-9537427 avoid use of implicit headings
…n-Upgrade-to-ERD-page
…ll-formed-elements
added he 'setFocus' method in RD2 _EnablementDelegateHelper.js and invoked it from RD2_EnablementDelegateController.js.
…6698-update-markup-to-contain-well-formed-elements W-9536698 ERD page should contain well-formed elements
…n-Upgrade-to-ERD-page
…6986-move-focus-to-new-content-on-Upgrade-to-ERD-page W-9536986-move focus to new content on Upgrade to Enhanced Recurring Donations page
Before checking access, fields in the GAU Allocations fieldset are checked for formula field type and permissionability.
…46973-add-formula-field-to-manage-allocations-fieldset W-15046973 Fix error on adding formula field to GAU allocations fieldset
Merge 252 bug fix into main
Change for template tag in bdiObjectMappings.html and bdiFieldMappingModal.html
…28778-invalid-markup-in-bdiObjectMappings W-16328778 Invalid markup in bdiObjectMappings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request was automatically generated because an automated merge hit a merge conflict