-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge feature/248 into feature/248__qa-npsp-contact-dupes #7211
Open
salesforce-org-metaci
wants to merge
147
commits into
feature/248__qa-npsp-contact-dupes
Choose a base branch
from
feature/248
base: feature/248__qa-npsp-contact-dupes
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Merge feature/248 into feature/248__qa-npsp-contact-dupes #7211
salesforce-org-metaci
wants to merge
147
commits into
feature/248__qa-npsp-contact-dupes
from
feature/248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A recent change to CumulusCI resulted in a regression for certain custom tasks. Before this commit: ```console $ cci task run is_rd2_enabled Error: module 'tasks' has no attribute 'is_rd2_enabled' Run this command for more information about debugging errors: cci error --help ``` This resulted in an error when running preflight checks for the `enhanced-recurring-donations` plan in MetaDeploy. After: ```console $ cci task run is_rd2_enabled is_rd2_enabled Description: This preflight check ensures that Enhanced Recurring Donations is enabled Class: tasks.check_rd2_enablement.is_rd2_enabled [...] ``` Co-authored-by: James Estevez <[email protected]>
…contact-dupes NPSP Potential Duplicates
salesforce-org-metaci
bot
requested review from
jstvz
and removed request for
a team
November 6, 2023 21:02
…s-not-updated-ge-batch-process W-15110724 - 250__fields-not-updated-ge-batch-process
'Upgrade process complete' heading is marked with a heading tag <h4> to overcome accessibility issue.
'Data Migration Run' was only styled to look like headings but wasn’t marked as such, hence added h2 heading tag explicitly.
…structure. In RD2_EnablementDelegate.cmp elements are reformed to maintain consistency and proper HTML structure.
To ensure that focus moves to new content when it updates, changes has been added to the RD2_EnablementDelegateController.js file for the Validate and Run Migration buttons.
…7427-avoid-use-of-implicit-headings w-9537427 avoid use of implicit headings
…n-Upgrade-to-ERD-page
…ll-formed-elements
added he 'setFocus' method in RD2 _EnablementDelegateHelper.js and invoked it from RD2_EnablementDelegateController.js.
…6698-update-markup-to-contain-well-formed-elements W-9536698 ERD page should contain well-formed elements
…n-Upgrade-to-ERD-page
…6986-move-focus-to-new-content-on-Upgrade-to-ERD-page W-9536986-move focus to new content on Upgrade to Enhanced Recurring Donations page
Before checking access, fields in the GAU Allocations fieldset are checked for formula field type and permissionability.
…46973-add-formula-field-to-manage-allocations-fieldset W-15046973 Fix error on adding formula field to GAU allocations fieldset
Merge 252 bug fix into main
Change for template tag in bdiObjectMappings.html and bdiFieldMappingModal.html
…28778-invalid-markup-in-bdiObjectMappings W-16328778 Invalid markup in bdiObjectMappings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request was automatically generated because an automated merge hit a merge conflict