[release/1.28.1] Disable python format checking #14600
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It disables python format checking because it is not working on yapf 0.22.0. ONE-DCO-1.0-Signed-off-by: Hyeongseok Oh <[email protected]>
|
If we don't need more patch on release/1.28.1, close this PR. |
|
Frankly speaking, I don't know what is going on with 1.28.1 release branch. |
|
@seanshpark I also don't know and I never heard about 1.28.1 release. |
|
@seanshpark It looks like about #14548 |
Hi, we gave up with asking to release 1.28.1, even if it will be useful for us. I believe we will wait until 1.30.0 will be released and try to bump ONE dependency in our project then. Eventually if there will be some issues we will ask to introduce some improvements in 1.30.1. So to summarize if this PR is related with our request to release 1.28.1 it can be safely closed. Thanks :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It disables python format checking because it is not working on yapf 0.22.0.
ONE-DCO-1.0-Signed-off-by: Hyeongseok Oh [email protected]
Relataed issue: #14596