Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update QuadraticSpline #354

Merged
merged 9 commits into from
Nov 12, 2024
Merged

Update QuadraticSpline #354

merged 9 commits into from
Nov 12, 2024

Conversation

SouthEndMusic
Copy link
Member

Fixes #353.

Sadly this kills Zygote support for QuadraticSpline as it uses the mutating Bspline evaluation functionality.

@SouthEndMusic SouthEndMusic changed the title Update QuadraticSpline Update QuadraticSpline Nov 12, 2024
ChrisRackauckas
ChrisRackauckas previously approved these changes Nov 12, 2024
View reviewed changes
Copy link
Member

@ChrisRackauckas ChrisRackauckas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a fine loss for something that's much more likely to be accurate.

@ChrisRackauckas
Copy link
Member

rebase?

@ChrisRackauckas ChrisRackauckas merged commit 26d6f11 into SciML:master Nov 12, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChrisRackauckas ChrisRackauckas ChrisRackauckas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unstable quadratic spline
2 participants
@SouthEndMusic @ChrisRackauckas