Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added ExponentialRK, IMEXMultistep and Linear Solvers #2308

Merged
merged 21 commits into from
Aug 4, 2024

Conversation

ParamThakkar123
Copy link
Contributor

Checklist

  • Appropriate tests were added
  • Any code changes were done in a way that does not break public API
  • All documentation related to code changes were updated
  • The new code follows the
    contributor guidelines, in particular the SciML Style Guide and
    COLPRAC.
  • Any new documentation only uses public API

Additional context

Add any other context about the problem here.
solves a part of #2177

@ChrisRackauckas ChrisRackauckas merged commit cb95437 into SciML:master Aug 4, 2024
37 of 41 checks passed
@ParamThakkar123
Copy link
Contributor Author

ParamThakkar123 commented Aug 4, 2024

@ChrisRackauckas What all things are yet to be done next ??

Are the points mentioned further in #2310 next ??

@ChrisRackauckas
Copy link
Member

I'm going to change up the CI #2311 so that it actually tests the submodules in isolation. I think this will likely find a few more issues with the individual subpackages that wasn't noticed when always running them with the global OrdinaryDiffEq. I might enjoy some help with that. Also we need to split differentiation, nonlinearsolve, and core and that's started in #2309 . These two pieces kind of need to go together, since all of the using OrdinaryDiffEq should become using OrdinaryDiffEqCore, so that in theory these can all be used in isolation. So there's still some more to do before we're really ready to release.

But if you want to claim your victory payout, I think you completed what I had originally outlined about splitting the solvers out, and I'd be willing to say that's completed and start that process.

@ParamThakkar123
Copy link
Contributor Author

I'm going to change up the CI #2311 so that it actually tests the submodules in isolation. I think this will likely find a few more issues with the individual subpackages that wasn't noticed when always running them with the global OrdinaryDiffEq. I might enjoy some help with that. Also we need to split differentiation, nonlinearsolve, and core and that's started in #2309 . These two pieces kind of need to go together, since all of the using OrdinaryDiffEq should become using OrdinaryDiffEqCore, so that in theory these can all be used in isolation. So there's still some more to do before we're really ready to release.

But if you want to claim your victory payout, I think you completed what I had originally outlined about splitting the solvers out, and I'd be willing to say that's completed and start that process.

Ok. I would also love to be a part of this further and help with the further processes that are yet to be done

@ParamThakkar123
Copy link
Contributor Author

@ChrisRackauckas You can assign me some tasks where you think I can help

@ParamThakkar123
Copy link
Contributor Author

But if you want to claim your victory payout, I think you completed what I had originally outlined about splitting the solvers out, and I'd be willing to say that's completed and start that process.

We can discuss this over the mail

@ChrisRackauckas
Copy link
Member

You can assign me some tasks where you think I can help

Thanks! I just merged #2311 which has some failing tests to handle. You can see the last commit I made which was making progress towards it. With this change to the CI, it's now testing each of the submodules as a separate package. This means that, unlike before, the Project.toml per-package is now being checked to be correct for the test dependencies. That'll take some working through. If you do that, then I can do the OrdinaryDiffEqDifferentiation/OrdinaryDiffEqNonlinear/OrdinaryDiffEqCore change, and then there will be another phase of fixing the Project.tomls so that each package has the right dependencies everywhere. Once that's done, the split is complete!

@ParamThakkar123
Copy link
Contributor Author

You can assign me some tasks where you think I can help

Thanks! I just merged #2311 which has some failing tests to handle. You can see the last commit I made which was making progress towards it. With this change to the CI, it's now testing each of the submodules as a separate package. This means that, unlike before, the Project.toml per-package is now being checked to be correct for the test dependencies. That'll take some working through. If you do that, then I can do the OrdinaryDiffEqDifferentiation/OrdinaryDiffEqNonlinear/OrdinaryDiffEqCore change, and then there will be another phase of fixing the Project.tomls so that each package has the right dependencies everywhere. Once that's done, the split is complete!

Ok I will take this part of adding the test dependencies to all the packages

@ParamThakkar123
Copy link
Contributor Author

@ChrisRackauckas just sent you an email on this : [email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants