-
-
Notifications
You must be signed in to change notification settings - Fork 210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added ExponentialRK, IMEXMultistep and Linear Solvers #2308
Conversation
lib/OrdinaryDiffEqExponentialRK/src/OrdinaryDiffEqExponentialRK.jl
Outdated
Show resolved
Hide resolved
lib/OrdinaryDiffEqExponentialRK/src/OrdinaryDiffEqExponentialRK.jl
Outdated
Show resolved
Hide resolved
lib/OrdinaryDiffEqExponentialRK/src/OrdinaryDiffEqExponentialRK.jl
Outdated
Show resolved
Hide resolved
lib/OrdinaryDiffEqExponentialRK/src/OrdinaryDiffEqExponentialRK.jl
Outdated
Show resolved
Hide resolved
@ChrisRackauckas What all things are yet to be done next ?? Are the points mentioned further in #2310 next ?? |
I'm going to change up the CI #2311 so that it actually tests the submodules in isolation. I think this will likely find a few more issues with the individual subpackages that wasn't noticed when always running them with the global OrdinaryDiffEq. I might enjoy some help with that. Also we need to split differentiation, nonlinearsolve, and core and that's started in #2309 . These two pieces kind of need to go together, since all of the But if you want to claim your victory payout, I think you completed what I had originally outlined about splitting the solvers out, and I'd be willing to say that's completed and start that process. |
Ok. I would also love to be a part of this further and help with the further processes that are yet to be done |
@ChrisRackauckas You can assign me some tasks where you think I can help |
We can discuss this over the mail |
Thanks! I just merged #2311 which has some failing tests to handle. You can see the last commit I made which was making progress towards it. With this change to the CI, it's now testing each of the submodules as a separate package. This means that, unlike before, the Project.toml per-package is now being checked to be correct for the test dependencies. That'll take some working through. If you do that, then I can do the OrdinaryDiffEqDifferentiation/OrdinaryDiffEqNonlinear/OrdinaryDiffEqCore change, and then there will be another phase of fixing the Project.tomls so that each package has the right dependencies everywhere. Once that's done, the split is complete! |
Ok I will take this part of adding the test dependencies to all the packages |
@ChrisRackauckas just sent you an email on this : [email protected] |
Checklist
contributor guidelines, in particular the SciML Style Guide and
COLPRAC.
Additional context
Add any other context about the problem here.
solves a part of #2177