Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: disable blinking cursor on display for x86 devices #2167

Merged
merged 9 commits into from
Dec 20, 2024
Merged

fix: disable blinking cursor on display for x86 devices #2167

merged 9 commits into from
Dec 20, 2024

Conversation

nicomiguelino
Copy link
Contributor

@nicomiguelino nicomiguelino commented Dec 19, 2024 •
edited
Loading

Issues Fixed

  • Blinking cursor appears on the top left of the connected display for x86 devices.

Description

  • Modifies startup files so that blinking cursor will be disabled on boot.

Checklist

  • I have performed a self-review of my own code.
  • New and existing unit tests pass locally and on CI with my changes.
  • I have done an end-to-end test for Raspberry Pi devices.
  • I have tested my changes for x86 devices.
  • I added a documentation for the changes I have made (when necessary).

Additional Information

Include any additional information that you think is necessary for this pull request,
including screenshots of the changes that you have made.

@nicomiguelino nicomiguelino marked this pull request as ready for review December 20, 2024 03:51
@nicomiguelino nicomiguelino requested a review from a team as a code owner December 20, 2024 03:51
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@nicomiguelino nicomiguelino merged commit f1dcaca into Screenly:master Dec 20, 2024
8 checks passed
@nicomiguelino nicomiguelino deleted the remove-x86-blinking-cursor branch December 20, 2024 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vpetersson vpetersson vpetersson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Anthias
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nicomiguelino @vpetersson