Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Parser::setOptions() instead of writing directly to Parser::$mOptions #112

Closed
wants to merge 1 commit into from
Closed

Use Parser::setOptions() instead of writing directly to Parser::$mOptions #112

wants to merge 1 commit into from

Conversation

cscott
Copy link
Contributor

@cscott cscott commented Apr 12, 2024

wmfgerrit pushed a commit to wikimedia/mediawiki that referenced this pull request Apr 14, 2024
@cscott
[Parser] Emit warnings for accesses to deprecated $mOptions property
add081f 
Code search:
  https://codesearch-beta.wmcloud.org/search/?q=arser-%3EmOptions%5Cb

Patches to non-deployed code:
* ProfessionalWiki/SubPageList#75
* PhpTagsFunctions: I1a72e88c5cc3d0587f085f5fa65d1f7ebb9fb602
* S5SlideShow: Ie2268432c9398af11fd02216a45df78e72609e15
* SemanticACL: I01243660d7241e094f60f5acb97726539c07c676
* VisualData: I1a972e159e6de3f94589a0c215d7f96c602b04bb
* Open-CSP/WikiSearch#50
* SemanticMediaWiki/SemanticFormsSelect#112
* SemanticMediaWiki/SemanticResultFormats#828
* haleyjd/WikiActivity#2
* thaider/Tweeki#273

Bug: T236810
Bug: T236812
Change-Id: I8b98e851e6536f1a02bc41a6253c9ffe7c50ed36
wmfgerrit pushed a commit to wikimedia/mediawiki that referenced this pull request Apr 16, 2024
@cscott
[Parser] Emit warnings for accesses to deprecated $mOptions property
942d168 
Code search:
  https://codesearch-beta.wmcloud.org/search/?q=arser-%3EmOptions%5Cb

Patches to non-deployed code:
* ProfessionalWiki/SubPageList#75
* PhpTagsFunctions: I1a72e88c5cc3d0587f085f5fa65d1f7ebb9fb602
* S5SlideShow: Ie2268432c9398af11fd02216a45df78e72609e15
* SemanticACL: I01243660d7241e094f60f5acb97726539c07c676
* VisualData: I1a972e159e6de3f94589a0c215d7f96c602b04bb
* Open-CSP/WikiSearch#50
* SemanticMediaWiki/SemanticFormsSelect#112
* SemanticMediaWiki/SemanticResultFormats#828
* haleyjd/WikiActivity#2
* thaider/Tweeki#273

Bug: T236810
Bug: T236812
Change-Id: I8b98e851e6536f1a02bc41a6253c9ffe7c50ed36
(cherry picked from commit add081f)
@gesinn-it-gea
Copy link
Member

Thanks for your PR. This has been fixed as part of e5b85d7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cscott @gesinn-it-gea