Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to wfFindFile again #838

Merged
merged 3 commits into from
Jun 12, 2024

Conversation

D-Groenewegen
Copy link
Contributor

No need to support the older method wfFindFile (pre-MW 1.34). Since SRF 4.0.x, the minimum version is MW 1.35. Also corrected an earlier oversight.
#778

No need to support older method. Since SRF 4.0.x (now obsolete), the minimum version is MW 1.35.
No need to support wfFindFile (MW 1.33 or older). SRF's minimum version is MW 1.34.
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 40.79%. Comparing base (c0dd4bb) to head (394f5f6).
Report is 25 commits behind head on master.

Files Patch % Lines
formats/dygraphs/SRF_Dygraphs.php 0.00% 2 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #838      +/-   ##
============================================
+ Coverage     40.12%   40.79%   +0.66%     
- Complexity     2332     2404      +72     
============================================
  Files            78       81       +3     
  Lines          8247     7852     -395     
============================================
- Hits           3309     3203     -106     
+ Misses         4938     4649     -289     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alexander-gesinn
Copy link

Thanks for your PR! We need to explain the CI and testing a little bit better :-) We now have Docker Compose based CI that can be used for testing locally by simply running "make ci". See https://github.com/gesinn-it-pub/docker-compose-ci

@gesinn-it-gea gesinn-it-gea merged commit c85d6c6 into SemanticMediaWiki:master Jun 12, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants