Bump postcss, postcss-custom-media, stylelint and stylelint-config-sass-guidelines #377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
…ss-guidelines Bumps [postcss](https://github.com/postcss/postcss) to 8.4.31 and updates ancestor dependencies [postcss](https://github.com/postcss/postcss), [postcss-custom-media](https://github.com/csstools/postcss-plugins/tree/HEAD/plugins/postcss-custom-media), [stylelint](https://github.com/stylelint/stylelint) and [stylelint-config-sass-guidelines](https://github.com/bjankord/stylelint-config-sass-guidelines). These dependencies need to be updated together. Updates `postcss` from 7.0.39 to 8.4.31 - [Release notes](https://github.com/postcss/postcss/releases) - [Changelog](https://github.com/postcss/postcss/blob/main/CHANGELOG.md) - [Commits](postcss/postcss@7.0.39...8.4.31) Updates `postcss-custom-media` from 7.0.8 to 10.0.2 - [Changelog](https://github.com/csstools/postcss-plugins/blob/main/plugins/postcss-custom-media/CHANGELOG.md) - [Commits](https://github.com/csstools/postcss-plugins/commits/HEAD/plugins/postcss-custom-media) Updates `stylelint` from 13.13.1 to 15.10.3 - [Release notes](https://github.com/stylelint/stylelint/releases) - [Changelog](https://github.com/stylelint/stylelint/blob/main/CHANGELOG.md) - [Commits](stylelint/stylelint@13.13.1...15.10.3) Updates `stylelint-config-sass-guidelines` from 7.1.0 to 10.0.0 - [Release notes](https://github.com/bjankord/stylelint-config-sass-guidelines/releases) - [Changelog](https://github.com/bjankord/stylelint-config-sass-guidelines/blob/main/CHANGELOG.md) - [Commits](bjankord/stylelint-config-sass-guidelines@v7.1.0...v10.0.0) --- updated-dependencies: - dependency-name: postcss dependency-type: indirect - dependency-name: postcss-custom-media dependency-type: direct:development - dependency-name: stylelint dependency-type: direct:development - dependency-name: stylelint-config-sass-guidelines dependency-type: direct:development ... Signed-off-by: dependabot[bot] <[email protected]>
dependabot
bot
added
the
dependencies
richardxia
requested changes
Oct 17, 2023
There was a problem hiding this comment.
This appears to cause a visual regression, where you can immediately see that the mobile-only hamburger menu appears in desktop mode. This is probably related to the postcss-custom-media plugin being bumped.
Let's not merge until we manually resolve this the issue.
The recent update to PostCSS and postcss-custom-media appears to have broken the latter, causing custom CSS media queries to not be processed. It's not clear exactly what changed that caused it, but it may have been one of nested packages. Regardless, it looks like the postcss-custom-media project's README was updated sometime earlier this year to explicitly mention that it may not work out of the box with CSS Modules, which we are using in this project. They recommend using the postcss-global-data package to ensure that the custom media definitions are available in all CSS modules. Adding that package appears to fix the issue, allowing the pages to look the same as before the package upgrades.
|
While I'm not exactly sure which package bump caused the issue, it looks like it can be explained by the section at the bottom of the postcss-custom-media package's README: https://github.com/csstools/postcss-plugins/blob/768449ddc7e226e735b9e507fd4fbd4c89c8de6c/plugins/postcss-custom-media/README.md#modular-css-processing In summary, CSS Modules doesn't work with the postcss-custom-media plugin unless you make sure your CSS file with the custom media definitions is imported into every CSS module. They recommend using the postcss-global-data plugin to do just that, and it seems to work well. I pushed this up to this branch in 90f10fb |
richardxia
approved these changes
Dec 5, 2023
|
cc @candywang, as an FYI I'm doing another bump of some packages. |
richardxia
deleted the
dependabot/npm_and_yarn/postcss-and-postcss-custom-media-and-stylelint-and-stylelint-config-sass-guidelines-8.4.31
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps postcss to 8.4.31 and updates ancestor dependencies postcss, postcss-custom-media, stylelint and stylelint-config-sass-guidelines. These dependencies need to be updated together.
Updates
postcssfrom 7.0.39 to 8.4.31Release notes
Sourced from postcss's releases.
... (truncated)
Changelog
Sourced from postcss's changelog.
... (truncated)
Commits
90208deRelease 8.4.31 version58cc860Fix carrier return parsing4fff8e4Improve pnpm test outputcd43ed1Update dependenciescaa916bUpdate dependencies8972f76Typo11a5286Typo45c5501Release 8.4.30 versionbc3c341Update linterb2be58aMerge pull request #1881 from romainmenke/improve-sourcemap-performance--phil...Updates
postcss-custom-mediafrom 7.0.8 to 10.0.2Changelog
Sourced from postcss-custom-media's changelog.
... (truncated)
Commits
Maintainer changes
This version was pushed to npm by alaguna, a new releaser for postcss-custom-media since your current version.
Updates
stylelintfrom 13.13.1 to 15.10.3Release notes
Sourced from stylelint's releases.
... (truncated)
Changelog
Sourced from stylelint's changelog.
... (truncated)
Commits
9e7319d15.10.30520c84Prepare 15.10.3 (#7089)97e5f89Bump lint-staged from 13.2.3 to 14.0.0 (#7133)e0651fdBump the eslint group with 1 update (#7132)83a3e2bUse newtestRuleConfigsfunction ofjest-preset-stylelint(#7124)a6df588Bump the csstools-parser group with 1 update (#7117)48a28b4Bump patch-package from 7.0.2 to 8.0.0 (#7115)d159011Bump the jest group with 2 updates (#7114)2f324b6Bump the eslint group with 2 updates (#7113)247c94cRefactor to replacechangelog-to-github-releasescript with GitHub Action (...Updates
stylelint-config-sass-guidelinesfrom 7.1.0 to 10.0.0Release notes
Sourced from stylelint-config-sass-guidelines's releases.
Changelog
Sourced from stylelint-config-sass-guidelines's changelog.
... (truncated)
Commits
ca13b6fReleased version 10.0.04441071Add scss/no-global-function-names rule (#280)45b3fa0Remove scss/at-mixin-pattern rule (#279)bf4d9cdRemove stylelint order plugin (#278)93314b8Update tape to latest versionb07865bUpdate README.mdb7be213Update CHANGELOG.mdb463824Bump minimatch from 3.0.4 to 3.1.2 (#277)35395a6Bump tape from 5.5.3 to 5.6.3 (#269)a742dc1Stylelint v15 update (#276)You can trigger a rebase of this PR by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)You can disable automated security fix PRs for this repo from the Security Alerts page.