Add new option to link for new apps #4808
Merged
+82
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
There is a bug for complex templates where some default config gets discarded.
Some context:
unable-to-reuse-current-config
--reset
, you are linking to a different app, we need to create a new toml and import the config from the remote app, we can't reuse the existing config. But it's there in the previous toml in case you want to copy it over.link
, so if the config from the template is valid but missing the apiKey, we can just update that field, no need to discard the contents of the toml!WHAT is this pull request doing?
app init
) and has acurrent
config format, we can ignore the api-key value and treat it as a valid config.How to test your changes?
Ask me or Paulo :)
Post-release steps
Measuring impact
How do we know this change was effective? Please choose one:
Checklist