Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dawn settings update #3683

Draft
wants to merge 72 commits into
base: main
Choose a base branch
from
Draft

Dawn settings update #3683

wants to merge 72 commits into from

Conversation

katycobb
Copy link

@katycobb katycobb commented Dec 10, 2024

PR Summary:

Our new dense UI makes the online store editor look and feel more like a pro tool, but the settings labels weren't built for this new interface. This is resulting in some too-long text which wraps and makes Dawn's settings look more crowded and tougher to scan than they should be.

This is also an opportunity to bring our settings content up to date based on our newest Polaris content uplift guidelines.

Why are these changes introduced?

Fixes #0.

What approach did you take?

Other considerations

Decision log

# Decision Alternatives Rationale Downsides
1

Visual impact on existing themes

Testing steps/scenarios

  • Step 1

Demo links

Checklist

Copy link
Contributor

@Roi-Arthur Roi-Arthur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here's a pass purely on settings wording

locales/en.default.schema.json Outdated Show resolved Hide resolved
locales/en.default.schema.json Outdated Show resolved Hide resolved
locales/en.default.schema.json Outdated Show resolved Hide resolved
locales/en.default.schema.json Show resolved Hide resolved
locales/en.default.schema.json Outdated Show resolved Hide resolved
locales/en.default.schema.json Outdated Show resolved Hide resolved
locales/en.default.schema.json Show resolved Hide resolved
locales/en.default.schema.json Show resolved Hide resolved
locales/en.default.schema.json Outdated Show resolved Hide resolved
locales/en.default.schema.json Show resolved Hide resolved
@tyleralsbury tyleralsbury force-pushed the setting-content-audit branch from e657c7c to 969acea Compare January 30, 2025 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants