Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This is the final step for separating document concerns. In order to support other document types like RBS, we need to ensure that the base
Document
class is generic and accounts for different types of@parse_result
.Implementation
This PR:
locate
outside of the parent Document since the implementation is Ruby specific (but also used in ERBDocument)It's a rather large PR, but the changes are all interdependent and I couldn't split it into smaller chunks.
Automated Tests
Existing tests cover the refactor.