Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Ruby LSP formatting range to comply with LSP specification #2438

Merged
merged 1 commit into from
Aug 28, 2024
Merged

Fix Ruby LSP formatting range to comply with LSP specification #2438

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion lib/ruby_lsp/requests/formatting.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,14 +58,16 @@ def perform
formatted_text = @active_formatter.run_formatting(@uri, @document)
return unless formatted_text

lines = @document.source.lines
size = @document.source.size

return if formatted_text.size == size && formatted_text == @document.source

[
Interface::TextEdit.new(
range: Interface::Range.new(
start: Interface::Position.new(line: 0, character: 0),
end: Interface::Position.new(line: size, character: size),
end: Interface::Position.new(line: lines.size, character: 0),
),
new_text: formatted_text,
),
Expand Down
Loading