Remove experimental features from extension and migrate old settings #2830
+25
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @vinistock and the rest of your teammates on |
vinistock
added
breaking-change
Graphite App
vinistock
removed
breaking-change
vinistock
added
vscode
Graphite App
vinistock
force-pushed
the
11-05-remove_experimental_features_from_extension_and_migrate_old_settings
branch
from
940436f
to
e8301a4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This PR removes the experimental features setting and automatically migrates users to the new model with feature flags. The equivalent of having experimental features enabled is now setting the "feature flag"
alltotrue, which enables everything regardless of rollout percentage.Implementation
Removed the old setting and added some temporary code to migrate people to the new setting style.